Re: [tip:core/urgent] WARN_ON_SMP(): Add comment to explain ({0;})

Ingo Molnar
2011-03-29T07:30:51Z

* Alexey Dobriyan <adobriyan@gmail.com> wrote:

> On Mon, Mar 28, 2011 at 11:09:00AM -0400, Steven Rostedt wrote:
> > Geeze, I never expected such a fuss over a simple change ;)
>
> And it's still broken ;-)
>
> WARN_ON_SMP(x) should expand to x, not 0.

Dunno, we really do not want to *guarantee* side-effects in WARN_ON()
constructs.

Thanks,

Ingo