From: Izik Eidus <izik.eidus@ravellosystems.com>
To: nai.xia@gmail.com
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Chris Wright <chrisw@sous-sol.org>,
Andrea Arcangeli <aarcange@redhat.com>,
Rik van Riel <riel@redhat.com>, linux-mm <linux-mm@kvack.org>
Subject: Re: [PATCH 0/2] ksm: take dirty bit as reference to avoid volatile pages
Date: Mon, 28 Mar 2011 16:59:02 +0200 [thread overview]
Message-ID: <4D90A236.9030200@ravellosystems.com> (raw)
In-Reply-To: <201103282214.19345.nai.xia@gmail.com>
On 03/28/2011 04:14 PM, Nai Xia wrote:
> Currently, ksm uses page checksum to detect volatile pages. Izik Eidus
> suggested that we could use pte dirty bit to optimize. This patch series
> adds this new logic.
>
Hi,
One small note:
When kvm will use ksm on intel cpu with extended page tables support,
the cpu won`t track
dirty bit, therefore the calc_hash() logic should be used in such cases
(untill intel will fadd this support in their cpus)...
Moreover I think that even though that AMD nested page tables does
update dirty bit, you still need
to sync it with the host page table using mmu notifiers ?
(Not that on regular application use case of ksm any of this should be
an issue)
next prev parent reply other threads:[~2011-03-28 15:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-28 14:14 [PATCH 0/2] ksm: take dirty bit as reference to avoid volatile pages Nai Xia
2011-03-28 14:59 ` Izik Eidus [this message]
2011-03-28 15:29 ` Nai Xia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D90A236.9030200@ravellosystems.com \
--to=izik.eidus@ravellosystems.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=chrisw@sous-sol.org \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nai.xia@gmail.com \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox