* [PATCH v2] microblaze: Fix level/edge irq sensibility
@ 2011-03-30 11:24 Michal Simek
2011-03-30 12:03 ` Thomas Gleixner
0 siblings, 1 reply; 5+ messages in thread
From: Michal Simek @ 2011-03-30 11:24 UTC (permalink / raw)
To: tglx; +Cc: linux-kernel, Michal Simek
Patches:
"microblaze: Convert to new irq function names"
sha (4adc192ec7d977c74c750320f289af9d61c1caca)
and
"microblaze: Use generic show_interrupts()"
sha(9d61c18b25726306c9231428c17db42e3ff29ba7)
should also setup edge/level in irq_set_chip_and_handler_name
name parameter.
Error log:
~ # cat /proc/interrupts
CPU0
2: 2 Xilinx INTC-Xilinx INTC eth0
3: 2 Xilinx INTC-Xilinx INTC eth0
4: 241 Xilinx INTC-Xilinx INTC timer
6: 108 Xilinx INTC-Xilinx INTC serial
Fixed:
~ # cat /proc/interrupts
CPU0
2: 2 Xilinx INTC-level eth0
3: 2 Xilinx INTC-level eth0
4: 238 Xilinx INTC-edge timer
6: 108 Xilinx INTC-level serial
Signed-off-by: Michal Simek <monstr@monstr.eu>
---
v2: Fix exchanged edge and level
---
arch/microblaze/kernel/intc.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/microblaze/kernel/intc.c b/arch/microblaze/kernel/intc.c
index 5ba7e16..c88f066 100644
--- a/arch/microblaze/kernel/intc.c
+++ b/arch/microblaze/kernel/intc.c
@@ -158,11 +158,11 @@ void __init init_IRQ(void)
for (i = 0; i < nr_irq; ++i) {
if (intr_type & (0x00000001 << i)) {
irq_set_chip_and_handler_name(i, &intc_dev,
- handle_edge_irq, intc_dev.name);
+ handle_edge_irq, "edge");
irq_clear_status_flags(i, IRQ_LEVEL);
} else {
irq_set_chip_and_handler_name(i, &intc_dev,
- handle_level_irq, intc_dev.name);
+ handle_level_irq, "level");
irq_set_status_flags(i, IRQ_LEVEL);
}
}
--
1.5.5.6
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2] microblaze: Fix level/edge irq sensibility
2011-03-30 11:24 [PATCH v2] microblaze: Fix level/edge irq sensibility Michal Simek
@ 2011-03-30 12:03 ` Thomas Gleixner
2011-03-30 12:05 ` Michal Simek
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Gleixner @ 2011-03-30 12:03 UTC (permalink / raw)
To: Michal Simek; +Cc: linux-kernel
On Wed, 30 Mar 2011, Michal Simek wrote:
> Patches:
> "microblaze: Convert to new irq function names"
> sha (4adc192ec7d977c74c750320f289af9d61c1caca)
> and
> "microblaze: Use generic show_interrupts()"
> sha(9d61c18b25726306c9231428c17db42e3ff29ba7)
>
> should also setup edge/level in irq_set_chip_and_handler_name
> name parameter.
>
> Error log:
> ~ # cat /proc/interrupts
> CPU0
> 2: 2 Xilinx INTC-Xilinx INTC eth0
> 3: 2 Xilinx INTC-Xilinx INTC eth0
> 4: 241 Xilinx INTC-Xilinx INTC timer
> 6: 108 Xilinx INTC-Xilinx INTC serial
>
> Fixed:
> ~ # cat /proc/interrupts
> CPU0
> 2: 2 Xilinx INTC-level eth0
> 3: 2 Xilinx INTC-level eth0
> 4: 238 Xilinx INTC-edge timer
> 6: 108 Xilinx INTC-level serial
>
> Signed-off-by: Michal Simek <monstr@monstr.eu>
Should I pick that up for the urgent fixes ?
> ---
>
> v2: Fix exchanged edge and level
> ---
> arch/microblaze/kernel/intc.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/microblaze/kernel/intc.c b/arch/microblaze/kernel/intc.c
> index 5ba7e16..c88f066 100644
> --- a/arch/microblaze/kernel/intc.c
> +++ b/arch/microblaze/kernel/intc.c
> @@ -158,11 +158,11 @@ void __init init_IRQ(void)
> for (i = 0; i < nr_irq; ++i) {
> if (intr_type & (0x00000001 << i)) {
> irq_set_chip_and_handler_name(i, &intc_dev,
> - handle_edge_irq, intc_dev.name);
> + handle_edge_irq, "edge");
> irq_clear_status_flags(i, IRQ_LEVEL);
> } else {
> irq_set_chip_and_handler_name(i, &intc_dev,
> - handle_level_irq, intc_dev.name);
> + handle_level_irq, "level");
> irq_set_status_flags(i, IRQ_LEVEL);
> }
> }
> --
> 1.5.5.6
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] microblaze: Fix level/edge irq sensibility
2011-03-30 12:03 ` Thomas Gleixner
@ 2011-03-30 12:05 ` Michal Simek
2011-03-30 12:08 ` Thomas Gleixner
0 siblings, 1 reply; 5+ messages in thread
From: Michal Simek @ 2011-03-30 12:05 UTC (permalink / raw)
To: Thomas Gleixner; +Cc: linux-kernel
Thomas Gleixner wrote:
> On Wed, 30 Mar 2011, Michal Simek wrote:
>
>> Patches:
>> "microblaze: Convert to new irq function names"
>> sha (4adc192ec7d977c74c750320f289af9d61c1caca)
>> and
>> "microblaze: Use generic show_interrupts()"
>> sha(9d61c18b25726306c9231428c17db42e3ff29ba7)
>>
>> should also setup edge/level in irq_set_chip_and_handler_name
>> name parameter.
>>
>> Error log:
>> ~ # cat /proc/interrupts
>> CPU0
>> 2: 2 Xilinx INTC-Xilinx INTC eth0
>> 3: 2 Xilinx INTC-Xilinx INTC eth0
>> 4: 241 Xilinx INTC-Xilinx INTC timer
>> 6: 108 Xilinx INTC-Xilinx INTC serial
>>
>> Fixed:
>> ~ # cat /proc/interrupts
>> CPU0
>> 2: 2 Xilinx INTC-level eth0
>> 3: 2 Xilinx INTC-level eth0
>> 4: 238 Xilinx INTC-edge timer
>> 6: 108 Xilinx INTC-level serial
>>
>> Signed-off-by: Michal Simek <monstr@monstr.eu>
>
> Should I pick that up for the urgent fixes ?
No you shouldn't. It can go through my tree.
You can give me ACK if you like.
Michal
--
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] microblaze: Fix level/edge irq sensibility
2011-03-30 12:05 ` Michal Simek
@ 2011-03-30 12:08 ` Thomas Gleixner
2011-03-30 12:08 ` Michal Simek
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Gleixner @ 2011-03-30 12:08 UTC (permalink / raw)
To: Michal Simek; +Cc: linux-kernel
On Wed, 30 Mar 2011, Michal Simek wrote:
> Thomas Gleixner wrote:
> > On Wed, 30 Mar 2011, Michal Simek wrote:
> >
> > > Patches:
> > > "microblaze: Convert to new irq function names"
> > > sha (4adc192ec7d977c74c750320f289af9d61c1caca)
> > > and
> > > "microblaze: Use generic show_interrupts()"
> > > sha(9d61c18b25726306c9231428c17db42e3ff29ba7)
> > >
> > > should also setup edge/level in irq_set_chip_and_handler_name
> > > name parameter.
> > >
> > > Error log:
> > > ~ # cat /proc/interrupts
> > > CPU0
> > > 2: 2 Xilinx INTC-Xilinx INTC eth0
> > > 3: 2 Xilinx INTC-Xilinx INTC eth0
> > > 4: 241 Xilinx INTC-Xilinx INTC timer
> > > 6: 108 Xilinx INTC-Xilinx INTC serial
> > >
> > > Fixed:
> > > ~ # cat /proc/interrupts
> > > CPU0
> > > 2: 2 Xilinx INTC-level eth0
> > > 3: 2 Xilinx INTC-level eth0
> > > 4: 238 Xilinx INTC-edge timer
> > > 6: 108 Xilinx INTC-level serial
> > >
> > > Signed-off-by: Michal Simek <monstr@monstr.eu>
> >
> > Should I pick that up for the urgent fixes ?
>
> No you shouldn't. It can go through my tree.
> You can give me ACK if you like.
Here you go:
Acked-by: Thomas Gleixner <tglx@linutronix.de>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] microblaze: Fix level/edge irq sensibility
2011-03-30 12:08 ` Thomas Gleixner
@ 2011-03-30 12:08 ` Michal Simek
0 siblings, 0 replies; 5+ messages in thread
From: Michal Simek @ 2011-03-30 12:08 UTC (permalink / raw)
To: Thomas Gleixner; +Cc: linux-kernel
Thomas Gleixner wrote:
> On Wed, 30 Mar 2011, Michal Simek wrote:
>
>> Thomas Gleixner wrote:
>>> On Wed, 30 Mar 2011, Michal Simek wrote:
>>>
>>>> Patches:
>>>> "microblaze: Convert to new irq function names"
>>>> sha (4adc192ec7d977c74c750320f289af9d61c1caca)
>>>> and
>>>> "microblaze: Use generic show_interrupts()"
>>>> sha(9d61c18b25726306c9231428c17db42e3ff29ba7)
>>>>
>>>> should also setup edge/level in irq_set_chip_and_handler_name
>>>> name parameter.
>>>>
>>>> Error log:
>>>> ~ # cat /proc/interrupts
>>>> CPU0
>>>> 2: 2 Xilinx INTC-Xilinx INTC eth0
>>>> 3: 2 Xilinx INTC-Xilinx INTC eth0
>>>> 4: 241 Xilinx INTC-Xilinx INTC timer
>>>> 6: 108 Xilinx INTC-Xilinx INTC serial
>>>>
>>>> Fixed:
>>>> ~ # cat /proc/interrupts
>>>> CPU0
>>>> 2: 2 Xilinx INTC-level eth0
>>>> 3: 2 Xilinx INTC-level eth0
>>>> 4: 238 Xilinx INTC-edge timer
>>>> 6: 108 Xilinx INTC-level serial
>>>>
>>>> Signed-off-by: Michal Simek <monstr@monstr.eu>
>>> Should I pick that up for the urgent fixes ?
>> No you shouldn't. It can go through my tree.
>> You can give me ACK if you like.
>
> Here you go:
>
> Acked-by: Thomas Gleixner <tglx@linutronix.de>
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-03-30 12:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-30 11:24 [PATCH v2] microblaze: Fix level/edge irq sensibility Michal Simek
2011-03-30 12:03 ` Thomas Gleixner
2011-03-30 12:05 ` Michal Simek
2011-03-30 12:08 ` Thomas Gleixner
2011-03-30 12:08 ` Michal Simek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox