From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755329Ab1DAJX0 (ORCPT <rfc822;w@1wt.eu>);
	Fri, 1 Apr 2011 05:23:26 -0400
Received: from wolverine02.qualcomm.com ([199.106.114.251]:49335 "EHLO
	wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755192Ab1DAJXZ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 1 Apr 2011 05:23:25 -0400
X-IronPort-AV: E=McAfee;i="5400,1158,6302"; a="83168550"
Message-ID: <4D959986.2040108@codeaurora.org>
Date: Fri, 01 Apr 2011 14:53:18 +0530
From: Anirudh Ghayal <aghayal@codeaurora.org>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.9.2.7) Gecko/20100713 Thunderbird/3.1.1
MIME-Version: 1.0
To: Stephen Boyd <sboyd@codeaurora.org>, linux-input@vger.kernel.org
CC: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
        Trilok Soni <tsoni@codeaurora.org>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: Re: [rtc-linux] Re: [PATCH 2/3] input: pmic8xxx_pwrkey: Add support
 for power key
References: <1301158345-22206-1-git-send-email-aghayal@codeaurora.org> <1301158345-22206-3-git-send-email-aghayal@codeaurora.org> <4D90F631.908@codeaurora.org>
In-Reply-To: <4D90F631.908@codeaurora.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Stephen,

Thanks for reviewing. I will submit a V2 patch with the changes.

On 3/29/2011 2:27 AM, Stephen Boyd wrote:
> On 3/26/2011 9:52 AM, Anirudh Ghayal wrote:
>> +static void pmic8xxx_pwrkey_timer(unsigned long handle)
>> +{
>> +	unsigned long flags;
>> +	struct pmic8xxx_pwrkey *pwrkey = (struct pmic8xxx_pwrkey *)handle;
>> +
>> +	spin_lock_irqsave(&pwrkey->lock, flags);
>> +	pwrkey->key_pressed = true;
>> +
>> +	input_report_key(pwrkey->pwr, KEY_POWER, 1);
>> +	input_sync(pwrkey->pwr);
>> +	spin_unlock_irqrestore(&pwrkey->lock, flags);
>> +}
>> +
>>
> [snip]
>> +
>> +static irqreturn_t pwrkey_release_irq(int irq, void *_pwrkey)
>> +{
>> +	struct pmic8xxx_pwrkey *pwrkey = _pwrkey;
>> +	unsigned long flags;
>> +
>> +	/* no pwrkey time, means no delay in pwr key reporting */
>> +	if (!pwrkey->pdata->pwrkey_time_ms) {
>> +		input_report_key(pwrkey->pwr, KEY_POWER, 0);
>> +		input_sync(pwrkey->pwr);
>> +		return IRQ_HANDLED;
>> +	}
>> +
>> +	spin_lock_irqsave(&pwrkey->lock, flags);
>> +	del_timer_sync(&pwrkey->timer);
>
> Can you call del_timer_sync() while holding the lock that your timer
> function also acquires? I thought lockdep would have complained loudly
> about that but I'm not sure. It looks like a deadlock scenario.
Right. I will move del_timer_sync outside the spinlock.

>
>> +static int __devinit pmic8xxx_pwrkey_probe(struct platform_device *pdev)
>> +{
>>
> [snip]
>> +
>> +	if (pdata->kpd_trigger_delay_us>  62500) {
>> +		dev_err(&pdev->dev, "invalid pwr key trigger delay\n");
>
> Nitpick: Can you spell out "power" here instead of pwr? Or use
> "kpd_trigger_delay_us" instead.
Ok.

>
>> +		return -EINVAL;
>> +	}
>> +
>> +	if (pdata->pwrkey_time_ms&&
>> +	     (pdata->pwrkey_time_ms<  500 || pdata->pwrkey_time_ms>  1000)) {
>> +		dev_err(&pdev->dev, "invalid pwr key time supplied\n");
>
Ok.
> Ditto
>
>> +
>> +	pon_cntl&= ~PON_CNTL_TRIG_DELAY_MASK;
>> +	pon_cntl |= (delay&  PON_CNTL_TRIG_DELAY_MASK);
>> +	pon_cntl |= (pdata->pull_up ? PON_CNTL_PULL_UP : ~PON_CNTL_PULL_UP);
>
> Did you just set a bunch of bits you didn't want to when pdata->pull_up
> == false?
Oops right. I will fix this.
>

Thank you,
~Anirudh

-- 
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.