From: "H. Peter Anvin" <hpa@zytor.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Ingo Molnar <mingo@redhat.com>, "Rafael J. Wysocki" <rjw@sisk.pl>,
Michael Leun <lkml20101129@newton.leun.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@suse.de>,
Mike Pagano <mpagano@gentoo.org>
Subject: Re: 2.6.38.2 breaks suspend to disk
Date: Fri, 01 Apr 2011 13:21:59 -0700 [thread overview]
Message-ID: <4D9633E7.1010707@zytor.com> (raw)
In-Reply-To: <4D962D72.2010501@kernel.org>
On 04/01/2011 12:54 PM, Yinghai Lu wrote:
>
> ok, please check if you are happy with this one.
>
The best would simply be:
mmu_cr4_features = read_cr4_safe();
If this has to run before we can handle exceptions, one can verify the
existence by testing for the CPUID instruction (a CPU has CR4 if and
only if it has CPUID):
if (boot_cpu_data.cpuid_level >= 0)
mmu_cr4_features = read_cr4_safe();
... since we set cpuid_level to -1 if there is no CPUID instruction.
-hpa
next prev parent reply other threads:[~2011-04-01 20:22 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-30 18:32 2.6.38.2 breaks suspend to disk Michael Leun
2011-03-31 5:14 ` Yinghai Lu
2011-03-31 7:05 ` Michael Leun
2011-03-31 14:48 ` Stefano Stabellini
2011-03-31 15:53 ` Michael Leun
2011-03-31 21:48 ` Rafael J. Wysocki
2011-03-31 22:20 ` Yinghai Lu
2011-04-01 11:32 ` Stefano Stabellini
2011-04-01 16:06 ` Yinghai Lu
2011-04-01 16:22 ` H. Peter Anvin
2011-04-01 17:14 ` Yinghai Lu
2011-04-01 18:15 ` Stefano Stabellini
2011-04-01 18:14 ` Stefano Stabellini
2011-04-01 18:55 ` H. Peter Anvin
2011-04-01 19:32 ` Yinghai Lu
2011-04-01 19:36 ` H. Peter Anvin
2011-04-01 19:54 ` Yinghai Lu
2011-04-01 20:21 ` H. Peter Anvin [this message]
2011-04-01 21:24 ` Yinghai Lu
2011-04-01 21:30 ` H. Peter Anvin
2011-04-01 21:37 ` Yinghai Lu
2011-04-01 21:42 ` H. Peter Anvin
2011-04-01 23:04 ` Yinghai Lu
2011-04-01 23:12 ` H. Peter Anvin
2011-04-02 0:10 ` Yinghai Lu
2011-04-01 23:54 ` Rafael J. Wysocki
2011-04-06 20:28 ` [tip:x86/urgent] x86, hibernate: Initialize mmu_cr4_features during boot tip-bot for H. Peter Anvin
2011-04-01 6:15 ` 2.6.38.2 breaks suspend to disk Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D9633E7.1010707@zytor.com \
--to=hpa@zytor.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lkml20101129@newton.leun.net \
--cc=mingo@redhat.com \
--cc=mpagano@gentoo.org \
--cc=rjw@sisk.pl \
--cc=stefano.stabellini@eu.citrix.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox