From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Florian Mickler <florian@mickler.org>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
David Rientjes <rientjes@google.com>, Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH] x86, numa_64: remove unused variable
Date: Sun, 03 Apr 2011 19:25:41 +0400 [thread overview]
Message-ID: <4D989175.9090400@gmail.com> (raw)
In-Reply-To: <1301843624-22364-1-git-send-email-florian@mickler.org>
On 04/03/2011 07:13 PM, Florian Mickler wrote:
> In case !CONFIG_ACPI_NUMA and !CONFIG_AMD_NUMA gcc emits a warning about
> the unused variable ret.
>
> As that variable is in fact not needed I choose to remove it.
>
> Signed-off-by: Florian Mickler <florian@mickler.org>
> ---
> arch/x86/mm/numa_64.c | 8 ++------
> 1 files changed, 2 insertions(+), 6 deletions(-)
>
As far as I remember David prefer to have 'ret' in place but since it causes
such a warn we better to drop it.
--
Cyrill
next prev parent reply other threads:[~2011-04-03 15:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-03 15:13 [PATCH] x86, numa_64: remove unused variable Florian Mickler
2011-04-03 15:25 ` Cyrill Gorcunov [this message]
2011-04-03 23:20 ` Tejun Heo
2011-04-04 15:00 ` [tip:x86/mm] x86-64, NUMA: Remove " tip-bot for Florian Mickler
2011-04-05 3:29 ` [PATCH] x86, numa_64: remove " David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D989175.9090400@gmail.com \
--to=gorcunov@gmail.com \
--cc=florian@mickler.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
--cc=tj@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox