From: Simon Budig <simon.budig@kernelconcepts.de>
To: Chase Douglas <chase.douglas@canonical.com>
Cc: Jeffrey Brown <jeffbrown@android.com>,
Jiri Kosina <jkosina@suse.cz>,
Henrik Rydberg <rydberg@euromail.se>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH resend] hid-magicmouse: Increase evdev buffer size
Date: Mon, 04 Apr 2011 14:20:21 +0200 [thread overview]
Message-ID: <4D99B785.9070602@kernelconcepts.de> (raw)
In-Reply-To: <4D975072.1040507@canonical.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 04/02/2011 06:36 PM, Chase Douglas wrote:
> On 04/01/2011 07:51 PM, Jeffrey Brown wrote:
>> I've got another change in the works that fixes this problem more
>> systematically.
>
> That would be great :). I still would like to see this patch added so
> it's released with the 2.6.39 kernel and backported to earlier stable
> releases. I hope that's not a problem.
Wouldn't it make sense to change the buffer logic in the input layer
that in the case of a buffer overrun the head gets pushed forward to the
next SYN_REPORT?
One symptom I witnessed with the bug was, that I got partial reports,
which especially in the case of a multitouch report (A-Type) creates
false release-events. This would be solved by the head-forwarding.
(one could even think about more fancy stuff like combining relative
events and keeping track of the absolute events, but this seems a bit
like overkill)
Thanks,
Simon
- --
Simon Budig kernel concepts GbR
simon.budig@kernelconcepts.de Sieghuetter Hauptweg 48
+49-271-771091-17 D-57072 Siegen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAk2Zt4UACgkQO2O/RXesiHByIgCgmHsujFhsYcM0wp7qEl+HytNh
wSMAoLygXVkU1Lx+jNgBA++H8OL6dNVR
=9+3z
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2011-04-04 12:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-01 21:03 [PATCH resend] hid-magicmouse: Increase evdev buffer size Chase Douglas
2011-04-01 23:51 ` Jeffrey Brown
2011-04-02 16:36 ` Chase Douglas
2011-04-04 12:20 ` Simon Budig [this message]
2011-04-04 12:43 ` Jiri Kosina
2011-04-04 18:13 ` Jeffrey Brown
2011-04-04 18:55 ` Chase Douglas
2011-04-04 21:39 ` Dmitry Torokhov
2011-04-04 21:46 ` Chase Douglas
2011-04-05 19:45 ` Chase Douglas
2011-04-06 13:18 ` Jiri Kosina
2011-04-04 11:50 ` Henrik Rydberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D99B785.9070602@kernelconcepts.de \
--to=simon.budig@kernelconcepts.de \
--cc=chase.douglas@canonical.com \
--cc=jeffbrown@android.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox