From: Chris Metcalf <cmetcalf@tilera.com>
To: James Hogan <james@albanarts.com>
Cc: David Howells <dhowells@redhat.com>,
Koichi Yasutake <yasutake.koichi@jp.panasonic.com>,
Andrew Morton <akpm@linux-foundation.org>,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
James Hogan <james.hogan@imgtec.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Paul Mundt <lethal@linux-sh.org>, Arnd Bergmann <arnd@arndb.de>,
<linux-am33-list@redhat.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tile,mn10300: add device parameter to dma_cache_sync()
Date: Mon, 4 Apr 2011 15:16:03 -0400 [thread overview]
Message-ID: <4D9A18F3.3090506@tilera.com> (raw)
In-Reply-To: <BANLkTi=wY2q49BRfZWempPRT7s=2Wa3YKQ@mail.gmail.com>
On 4/4/2011 11:21 AM, James Hogan wrote:
> From: James Hogan <james.hogan@imgtec.com>
>
> Note: I'm not in a position to compile test this patch, but I don't
> foresee any problems.
>
> Since v2.6.20 "Pass struct dev pointer to dma_cache_sync()"
> (d3fa72e4556ec1f04e46a0d561d9e785ecaa173d), dma_cache_sync() takes a
> struct dev pointer, but these appear to be missing from the tile and
> mn10300 implementations, so add them.
>
> Signed-off-by: James Hogan <james.hogan@imgtec.com>
> ---
> arch/mn10300/include/asm/dma-mapping.h | 2 +-
> arch/tile/include/asm/dma-mapping.h | 3 ++-
> arch/tile/kernel/pci-dma.c | 2 +-
This change looks fine for tile (not compile-tested but pretty obvious), so
Acked-by: Chris Metcalf <cmetcalf@tilera.com>
assuming you're planning to push this up yourself.
Apparently we've never tried to build anything that uses this API
(sata_dwc_460ex.c, lasi_82596.c, 53c700.c, etc.).
--
Chris Metcalf, Tilera Corp.
http://www.tilera.com
next prev parent reply other threads:[~2011-04-04 19:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-04 15:21 [PATCH] tile,mn10300: add device parameter to dma_cache_sync() James Hogan
2011-04-04 17:50 ` FUJITA Tomonori
2011-04-04 19:50 ` James Hogan
2011-04-08 4:09 ` FUJITA Tomonori
2011-04-04 19:16 ` Chris Metcalf [this message]
2011-04-04 23:20 ` James Hogan
2011-04-05 13:16 ` Chris Metcalf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D9A18F3.3090506@tilera.com \
--to=cmetcalf@tilera.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=dhowells@redhat.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=james.hogan@imgtec.com \
--cc=james@albanarts.com \
--cc=konrad.wilk@oracle.com \
--cc=lethal@linux-sh.org \
--cc=linux-am33-list@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yasutake.koichi@jp.panasonic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox