public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@cam.ac.uk>
To: Sonny Rao <sonnyrao@chromium.org>
Cc: linux-pm@lists.linux-foundation.org, bleung@chromium.org,
	snanda@chromium.org, Greg Kroah-Hartman <gregkh@suse.de>,
	Manuel Stahl <manuel.stahl@iis.fraunhofer.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	Phillip Kurtenbach <pkurtenbach@gmail.com>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: Re: [PATCH] Enable async suspend/resume on industrial IO devices
Date: Wed, 06 Apr 2011 11:59:10 +0100	[thread overview]
Message-ID: <4D9C477E.4050400@cam.ac.uk> (raw)
In-Reply-To: <1302057915-13549-1-git-send-email-sonnyrao@chromium.org>

On 04/06/11 03:45, Sonny Rao wrote:
> Industrial I/O devices can sometimes take a long time to resume,
> allowing them to be asynchronus saves 50ms on one light sensor
> 
Hi Sonny,

cc'd linux-iio

I'm not particularly familiar with this.  Are there any disadvantages?
I just wonder if it would be better to push this into individual drivers
rather than the core?

Jonathan
> Signed-off-by: Sonny Rao <sonnyrao@chromium.org>
> 
> ---
>  drivers/staging/iio/industrialio-core.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/staging/iio/industrialio-core.c b/drivers/staging/iio/industrialio-core.c
> index 768f448..a4b099f 100644
> --- a/drivers/staging/iio/industrialio-core.c
> +++ b/drivers/staging/iio/industrialio-core.c
> @@ -811,6 +811,8 @@ int iio_device_register(struct iio_dev *dev_info)
>  	if (dev_info->modes & INDIO_RING_TRIGGERED)
>  		iio_device_register_trigger_consumer(dev_info);
>  
> +	device_enable_async_suspend(&dev_info->dev);
> +
>  	return 0;
>  
>  error_free_sysfs:


  reply	other threads:[~2011-04-06 10:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-06  2:45 [PATCH] Enable async suspend/resume on industrial IO devices Sonny Rao
2011-04-06 10:59 ` Jonathan Cameron [this message]
2011-04-06 22:47   ` Sonny Rao
2011-04-07 11:29     ` Jonathan Cameron
2011-04-08  3:26       ` Sonny Rao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D9C477E.4050400@cam.ac.uk \
    --to=jic23@cam.ac.uk \
    --cc=akpm@linux-foundation.org \
    --cc=bleung@chromium.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@suse.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=manuel.stahl@iis.fraunhofer.de \
    --cc=pkurtenbach@gmail.com \
    --cc=snanda@chromium.org \
    --cc=sonnyrao@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox