* [PATCH v2] gpio-charger: Add gpio_charger_resume @ 2011-04-03 2:13 Benson Leung 2011-04-06 9:08 ` Benson Leung 2011-04-06 23:55 ` [PATCH v3] " Benson Leung 0 siblings, 2 replies; 8+ messages in thread From: Benson Leung @ 2011-04-03 2:13 UTC (permalink / raw) To: lars, cbouatmailru; +Cc: rklein, linux-kernel, Benson Leung Gpio charger should notify if the gpio state had changed during suspend. This will send a CHANGED event each time the system resumes, ensuring a plug/unplug of the charger is not missed. Signed-off-by: Benson Leung <bleung@chromium.org> -- Version history : v2 : Changed to use dev_pm_ops v1 : Initial --- drivers/power/gpio-charger.c | 20 ++++++++++++++++++++ 1 files changed, 20 insertions(+), 0 deletions(-) diff --git a/drivers/power/gpio-charger.c b/drivers/power/gpio-charger.c index 25b88ac..df29059 100644 --- a/drivers/power/gpio-charger.c +++ b/drivers/power/gpio-charger.c @@ -161,12 +161,32 @@ static int __devexit gpio_charger_remove(struct platform_device *pdev) return 0; } +#if defined(CONFIG_PM) +static int gpio_charger_resume(struct device *dev) +{ + struct platform_device *pdev = to_platform_device(dev); + struct gpio_charger *gpio_charger = platform_get_drvdata(pdev); + + power_supply_changed(&gpio_charger->charger); + + return 0; +} + +static const struct dev_pm_ops gpio_charger_pm_ops = { + .resume = gpio_charger_resume, +}; +#endif + + static struct platform_driver gpio_charger_driver = { .probe = gpio_charger_probe, .remove = __devexit_p(gpio_charger_remove), .driver = { .name = "gpio-charger", .owner = THIS_MODULE, +#if defined(CONFIG_PM) + .pm = &gpio_charger_pm_ops, +#endif }, }; -- 1.7.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2] gpio-charger: Add gpio_charger_resume 2011-04-03 2:13 [PATCH v2] gpio-charger: Add gpio_charger_resume Benson Leung @ 2011-04-06 9:08 ` Benson Leung 2011-04-06 14:40 ` Lars-Peter Clausen 2011-04-06 23:55 ` [PATCH v3] " Benson Leung 1 sibling, 1 reply; 8+ messages in thread From: Benson Leung @ 2011-04-06 9:08 UTC (permalink / raw) To: lars, cbouatmailru; +Cc: rklein, linux-kernel, Benson Leung Hi Lars, Please take another look. Thanks, Benson On Sat, Apr 2, 2011 at 7:13 PM, Benson Leung <bleung@chromium.org> wrote: > Gpio charger should notify if the gpio state had changed > during suspend. This will send a CHANGED event each time > the system resumes, ensuring a plug/unplug of the charger > is not missed. > > Signed-off-by: Benson Leung <bleung@chromium.org> > > -- > Version history : > v2 : Changed to use dev_pm_ops > v1 : Initial > --- > drivers/power/gpio-charger.c | 20 ++++++++++++++++++++ > 1 files changed, 20 insertions(+), 0 deletions(-) > > diff --git a/drivers/power/gpio-charger.c b/drivers/power/gpio-charger.c > index 25b88ac..df29059 100644 > --- a/drivers/power/gpio-charger.c > +++ b/drivers/power/gpio-charger.c > @@ -161,12 +161,32 @@ static int __devexit gpio_charger_remove(struct platform_device *pdev) > return 0; > } > > +#if defined(CONFIG_PM) > +static int gpio_charger_resume(struct device *dev) > +{ > + struct platform_device *pdev = to_platform_device(dev); > + struct gpio_charger *gpio_charger = platform_get_drvdata(pdev); > + > + power_supply_changed(&gpio_charger->charger); > + > + return 0; > +} > + > +static const struct dev_pm_ops gpio_charger_pm_ops = { > + .resume = gpio_charger_resume, > +}; > +#endif > + > + > static struct platform_driver gpio_charger_driver = { > .probe = gpio_charger_probe, > .remove = __devexit_p(gpio_charger_remove), > .driver = { > .name = "gpio-charger", > .owner = THIS_MODULE, > +#if defined(CONFIG_PM) > + .pm = &gpio_charger_pm_ops, > +#endif > }, > }; > > -- > 1.7.1 > > -- Benson Leung Software Engineer, Chrom* OS bleung@chromium.org ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] gpio-charger: Add gpio_charger_resume 2011-04-06 9:08 ` Benson Leung @ 2011-04-06 14:40 ` Lars-Peter Clausen 2011-04-06 20:58 ` Benson Leung 0 siblings, 1 reply; 8+ messages in thread From: Lars-Peter Clausen @ 2011-04-06 14:40 UTC (permalink / raw) To: Benson Leung; +Cc: cbouatmailru, rklein, linux-kernel On 04/06/2011 11:08 AM, Benson Leung wrote: > Hi Lars, > > Please take another look. > > Thanks, > Benson > Hi Some minor issues: > On Sat, Apr 2, 2011 at 7:13 PM, Benson Leung <bleung@chromium.org> wrote: >> Gpio charger should notify if the gpio state had changed >> during suspend. This will send a CHANGED event each time >> the system resumes, ensuring a plug/unplug of the charger >> is not missed. >> >> Signed-off-by: Benson Leung <bleung@chromium.org> >> >> -- >> Version history : >> v2 : Changed to use dev_pm_ops >> v1 : Initial >> --- >> drivers/power/gpio-charger.c | 20 ++++++++++++++++++++ >> 1 files changed, 20 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/power/gpio-charger.c b/drivers/power/gpio-charger.c >> index 25b88ac..df29059 100644 >> --- a/drivers/power/gpio-charger.c >> +++ b/drivers/power/gpio-charger.c >> @@ -161,12 +161,32 @@ static int __devexit gpio_charger_remove(struct platform_device *pdev) >> return 0; >> } >> >> +#if defined(CONFIG_PM) #ifdef CONFIG_PM_SLEEP >> +static int gpio_charger_resume(struct device *dev) >> +{ >> + struct platform_device *pdev = to_platform_device(dev); >> + struct gpio_charger *gpio_charger = platform_get_drvdata(pdev); >> + >> + power_supply_changed(&gpio_charger->charger); >> + >> + return 0; >> +} >> + >> +static const struct dev_pm_ops gpio_charger_pm_ops = { >> + .resume = gpio_charger_resume, >> +}; >> +#endif static SIMPLE_DEV_PM_OPS(gpio_charger_pm_ops, gpio_charger_resume, NULL); This will also setup the pm hooks for suspend to disk. And SIMPLE_DEV_PM_OPS will also ignore the callbacks if CONFIG_PM_SLEEP is not set, so it can go outside of the #ifdef CONFIG_PM_SLEEP and you can also get rid of the #ifdef ... >> + >> + >> static struct platform_driver gpio_charger_driver = { >> .probe = gpio_charger_probe, >> .remove = __devexit_p(gpio_charger_remove), >> .driver = { >> .name = "gpio-charger", >> .owner = THIS_MODULE, >> +#if defined(CONFIG_PM) >> + .pm = &gpio_charger_pm_ops, >> +#endif ... here. >> }, >> }; >> >> -- >> 1.7.1 >> >> > > > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] gpio-charger: Add gpio_charger_resume 2011-04-06 14:40 ` Lars-Peter Clausen @ 2011-04-06 20:58 ` Benson Leung 0 siblings, 0 replies; 8+ messages in thread From: Benson Leung @ 2011-04-06 20:58 UTC (permalink / raw) To: Lars-Peter Clausen; +Cc: cbouatmailru, rklein, linux-kernel Thanks Lars, v3 coming right up. Benson On Wed, Apr 6, 2011 at 7:40 AM, Lars-Peter Clausen <lars@metafoo.de> wrote: > On 04/06/2011 11:08 AM, Benson Leung wrote: >> Hi Lars, >> >> Please take another look. >> >> Thanks, >> Benson >> > > Hi > > Some minor issues: > >> On Sat, Apr 2, 2011 at 7:13 PM, Benson Leung <bleung@chromium.org> wrote: >>> Gpio charger should notify if the gpio state had changed >>> during suspend. This will send a CHANGED event each time >>> the system resumes, ensuring a plug/unplug of the charger >>> is not missed. >>> >>> Signed-off-by: Benson Leung <bleung@chromium.org> >>> >>> -- >>> Version history : >>> v2 : Changed to use dev_pm_ops >>> v1 : Initial >>> --- >>> drivers/power/gpio-charger.c | 20 ++++++++++++++++++++ >>> 1 files changed, 20 insertions(+), 0 deletions(-) >>> >>> diff --git a/drivers/power/gpio-charger.c b/drivers/power/gpio-charger.c >>> index 25b88ac..df29059 100644 >>> --- a/drivers/power/gpio-charger.c >>> +++ b/drivers/power/gpio-charger.c >>> @@ -161,12 +161,32 @@ static int __devexit gpio_charger_remove(struct platform_device *pdev) >>> return 0; >>> } >>> >>> +#if defined(CONFIG_PM) > > #ifdef CONFIG_PM_SLEEP > >>> +static int gpio_charger_resume(struct device *dev) >>> +{ >>> + struct platform_device *pdev = to_platform_device(dev); >>> + struct gpio_charger *gpio_charger = platform_get_drvdata(pdev); >>> + >>> + power_supply_changed(&gpio_charger->charger); >>> + >>> + return 0; >>> +} >>> + >>> +static const struct dev_pm_ops gpio_charger_pm_ops = { >>> + .resume = gpio_charger_resume, >>> +}; >>> +#endif > > static SIMPLE_DEV_PM_OPS(gpio_charger_pm_ops, gpio_charger_resume, NULL); > > This will also setup the pm hooks for suspend to disk. > And SIMPLE_DEV_PM_OPS will also ignore the callbacks if CONFIG_PM_SLEEP is not > set, so it can go outside of the #ifdef CONFIG_PM_SLEEP and you can also get > rid of the #ifdef ... > >>> + >>> + >>> static struct platform_driver gpio_charger_driver = { >>> .probe = gpio_charger_probe, >>> .remove = __devexit_p(gpio_charger_remove), >>> .driver = { >>> .name = "gpio-charger", >>> .owner = THIS_MODULE, >>> +#if defined(CONFIG_PM) >>> + .pm = &gpio_charger_pm_ops, >>> +#endif > > ... here. > >>> }, >>> }; >>> >>> -- >>> 1.7.1 >>> >>> >> >> >> > > -- Benson Leung Software Engineer, Chrom* OS bleung@chromium.org ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v3] gpio-charger: Add gpio_charger_resume 2011-04-03 2:13 [PATCH v2] gpio-charger: Add gpio_charger_resume Benson Leung 2011-04-06 9:08 ` Benson Leung @ 2011-04-06 23:55 ` Benson Leung 2011-04-07 0:15 ` Lars-Peter Clausen 1 sibling, 1 reply; 8+ messages in thread From: Benson Leung @ 2011-04-06 23:55 UTC (permalink / raw) To: lars, cbouatmailru; +Cc: rklein, linux-kernel, Benson Leung Gpio charger should notify if the gpio state had changed during suspend. This will send a CHANGED event each time the system resumes, ensuring a plug/unplug of the charger is not missed. Signed-off-by: Benson Leung <bleung@chromium.org> -- Version history : v3 : Use SIMPLE_DEV_PM_OPS v2 : Changed to use dev_ms_ops v1 : Initial --- drivers/power/gpio-charger.c | 15 +++++++++++++++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/drivers/power/gpio-charger.c b/drivers/power/gpio-charger.c index 25b88ac..718f2c5 100644 --- a/drivers/power/gpio-charger.c +++ b/drivers/power/gpio-charger.c @@ -161,12 +161,27 @@ static int __devexit gpio_charger_remove(struct platform_device *pdev) return 0; } +#ifdef CONFIG_PM_SLEEP +static int gpio_charger_resume(struct device *dev) +{ + struct platform_device *pdev = to_platform_device(dev); + struct gpio_charger *gpio_charger = platform_get_drvdata(pdev); + + power_supply_changed(&gpio_charger->charger); + + return 0; +} +#endif + +static SIMPLE_DEV_PM_OPS(gpio_charger_pm_ops, NULL, gpio_charger_resume); + static struct platform_driver gpio_charger_driver = { .probe = gpio_charger_probe, .remove = __devexit_p(gpio_charger_remove), .driver = { .name = "gpio-charger", .owner = THIS_MODULE, + .pm = &gpio_charger_pm_ops, }, }; -- 1.7.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v3] gpio-charger: Add gpio_charger_resume 2011-04-06 23:55 ` [PATCH v3] " Benson Leung @ 2011-04-07 0:15 ` Lars-Peter Clausen 2011-04-12 4:19 ` Benson Leung 0 siblings, 1 reply; 8+ messages in thread From: Lars-Peter Clausen @ 2011-04-07 0:15 UTC (permalink / raw) To: Benson Leung; +Cc: cbouatmailru, rklein, linux-kernel On 04/07/2011 01:55 AM, Benson Leung wrote: > Gpio charger should notify if the gpio state had changed > during suspend. This will send a CHANGED event each time > the system resumes, ensuring a plug/unplug of the charger > is not missed. > > Signed-off-by: Benson Leung <bleung@chromium.org> Acked-By: Lars-Peter Clausen <lars@metafoo.de> > > -- > Version history : > v3 : Use SIMPLE_DEV_PM_OPS > v2 : Changed to use dev_ms_ops > v1 : Initial > --- > drivers/power/gpio-charger.c | 15 +++++++++++++++ > 1 files changed, 15 insertions(+), 0 deletions(-) > > diff --git a/drivers/power/gpio-charger.c b/drivers/power/gpio-charger.c > index 25b88ac..718f2c5 100644 > --- a/drivers/power/gpio-charger.c > +++ b/drivers/power/gpio-charger.c > @@ -161,12 +161,27 @@ static int __devexit gpio_charger_remove(struct platform_device *pdev) > return 0; > } > > +#ifdef CONFIG_PM_SLEEP > +static int gpio_charger_resume(struct device *dev) > +{ > + struct platform_device *pdev = to_platform_device(dev); > + struct gpio_charger *gpio_charger = platform_get_drvdata(pdev); > + > + power_supply_changed(&gpio_charger->charger); > + > + return 0; > +} > +#endif > + > +static SIMPLE_DEV_PM_OPS(gpio_charger_pm_ops, NULL, gpio_charger_resume); > + > static struct platform_driver gpio_charger_driver = { > .probe = gpio_charger_probe, > .remove = __devexit_p(gpio_charger_remove), > .driver = { > .name = "gpio-charger", > .owner = THIS_MODULE, > + .pm = &gpio_charger_pm_ops, > }, > }; > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v3] gpio-charger: Add gpio_charger_resume 2011-04-07 0:15 ` Lars-Peter Clausen @ 2011-04-12 4:19 ` Benson Leung 2011-04-20 17:25 ` Anton Vorontsov 0 siblings, 1 reply; 8+ messages in thread From: Benson Leung @ 2011-04-12 4:19 UTC (permalink / raw) To: Lars-Peter Clausen, cbouatmailru; +Cc: rklein, linux-kernel Thanks Lars. Hi Anton, Can this patch be applied? Thanks, Benson On Wed, Apr 6, 2011 at 5:15 PM, Lars-Peter Clausen <lars@metafoo.de> wrote: > On 04/07/2011 01:55 AM, Benson Leung wrote: >> Gpio charger should notify if the gpio state had changed >> during suspend. This will send a CHANGED event each time >> the system resumes, ensuring a plug/unplug of the charger >> is not missed. >> >> Signed-off-by: Benson Leung <bleung@chromium.org> > Acked-By: Lars-Peter Clausen <lars@metafoo.de> > >> >> -- >> Version history : >> v3 : Use SIMPLE_DEV_PM_OPS >> v2 : Changed to use dev_ms_ops >> v1 : Initial >> --- >> drivers/power/gpio-charger.c | 15 +++++++++++++++ >> 1 files changed, 15 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/power/gpio-charger.c b/drivers/power/gpio-charger.c >> index 25b88ac..718f2c5 100644 >> --- a/drivers/power/gpio-charger.c >> +++ b/drivers/power/gpio-charger.c >> @@ -161,12 +161,27 @@ static int __devexit gpio_charger_remove(struct platform_device *pdev) >> return 0; >> } >> >> +#ifdef CONFIG_PM_SLEEP >> +static int gpio_charger_resume(struct device *dev) >> +{ >> + struct platform_device *pdev = to_platform_device(dev); >> + struct gpio_charger *gpio_charger = platform_get_drvdata(pdev); >> + >> + power_supply_changed(&gpio_charger->charger); >> + >> + return 0; >> +} >> +#endif >> + >> +static SIMPLE_DEV_PM_OPS(gpio_charger_pm_ops, NULL, gpio_charger_resume); >> + >> static struct platform_driver gpio_charger_driver = { >> .probe = gpio_charger_probe, >> .remove = __devexit_p(gpio_charger_remove), >> .driver = { >> .name = "gpio-charger", >> .owner = THIS_MODULE, >> + .pm = &gpio_charger_pm_ops, >> }, >> }; >> > > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v3] gpio-charger: Add gpio_charger_resume 2011-04-12 4:19 ` Benson Leung @ 2011-04-20 17:25 ` Anton Vorontsov 0 siblings, 0 replies; 8+ messages in thread From: Anton Vorontsov @ 2011-04-20 17:25 UTC (permalink / raw) To: Benson Leung; +Cc: Lars-Peter Clausen, rklein, linux-kernel On Mon, Apr 11, 2011 at 09:19:42PM -0700, Benson Leung wrote: > Thanks Lars. > > Hi Anton, > > Can this patch be applied? Applied, thanks! > On Wed, Apr 6, 2011 at 5:15 PM, Lars-Peter Clausen <lars@metafoo.de> wrote: > > On 04/07/2011 01:55 AM, Benson Leung wrote: > >> Gpio charger should notify if the gpio state had changed > >> during suspend. This will send a CHANGED event each time > >> the system resumes, ensuring a plug/unplug of the charger > >> is not missed. > >> > >> Signed-off-by: Benson Leung <bleung@chromium.org> > > Acked-By: Lars-Peter Clausen <lars@metafoo.de> -- Anton Vorontsov Email: cbouatmailru@gmail.com ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2011-04-20 17:25 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-04-03 2:13 [PATCH v2] gpio-charger: Add gpio_charger_resume Benson Leung 2011-04-06 9:08 ` Benson Leung 2011-04-06 14:40 ` Lars-Peter Clausen 2011-04-06 20:58 ` Benson Leung 2011-04-06 23:55 ` [PATCH v3] " Benson Leung 2011-04-07 0:15 ` Lars-Peter Clausen 2011-04-12 4:19 ` Benson Leung 2011-04-20 17:25 ` Anton Vorontsov
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox