From: Stephen Boyd <sboyd@codeaurora.org>
To: Len Brown <len.brown@intel.com>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
Kevin Hilman <khilman@deeprootsystems.com>,
Paul Mundt <lethal@linux-sh.org>,
linux-kernel@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH] cpuidle: Fix build on ARM and SH
Date: Wed, 06 Apr 2011 22:57:19 -0700 [thread overview]
Message-ID: <4D9D523F.4090506@codeaurora.org> (raw)
In-Reply-To: <1301894612-10471-1-git-send-email-broonie@opensource.wolfsonmicro.com>
On 4/3/2011 10:23 PM, Mark Brown wrote:
> Commit 5f8cf82 (cpuidle: stop using pm_idle) converted arches to use
> cpuidle_idle_call() but contained typos on ARM and SH transposing the
> function name into cpuidle_call_idle().
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
When will this patch get into linux-next? Every ARM and SH build has
failed for the past 3 days presumably due to this. Stephen, can you pick
it up for the time being?
> ---
> arch/arm/kernel/process.c | 2 +-
> arch/sh/kernel/idle.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
> index dc9d685..f47660e 100644
> --- a/arch/arm/kernel/process.c
> +++ b/arch/arm/kernel/process.c
> @@ -197,7 +197,7 @@ void cpu_idle(void)
> cpu_relax();
> } else {
> stop_critical_timings();
> - if (cpuidle_call_idle())
> + if (cpuidle_idle_call())
> pm_idle();
> start_critical_timings();
> /*
> diff --git a/arch/sh/kernel/idle.c b/arch/sh/kernel/idle.c
> index 9c7099e..1db1968 100644
> --- a/arch/sh/kernel/idle.c
> +++ b/arch/sh/kernel/idle.c
> @@ -101,7 +101,7 @@ void cpu_idle(void)
> local_irq_disable();
> /* Don't trace irqs off for idle */
> stop_critical_timings();
> - if (cpuidle_call_idle())
> + if (cpuidle_idle_call())
> pm_idle();
> /*
> * Sanity check to ensure that pm_idle() returns
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2011-04-07 5:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-04 5:23 [PATCH] cpuidle: Fix build on ARM and SH Mark Brown
2011-04-07 5:57 ` Stephen Boyd [this message]
2011-04-15 4:08 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2011-04-04 5:27 Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D9D523F.4090506@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=khilman@deeprootsystems.com \
--cc=len.brown@intel.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox