From: Alexander Holler <holler@ahsoftware.de>
To: Nico Erfurth <ne@erfurth.eu>
Cc: Eric Cooper <ecc@cmu.edu>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Nicolas Pitre <nico@fluxnic.net>
Subject: Re: [PATCH 0/2] ARM: Unify setup for Marvell SheevaPlugs and Seagate DockStars
Date: Thu, 07 Apr 2011 11:44:02 +0200 [thread overview]
Message-ID: <4D9D8762.3080207@ahsoftware.de> (raw)
In-Reply-To: <4D9D85E4.2040606@erfurth.eu>
Am 07.04.2011 11:37, schrieb Nico Erfurth:
> Alexander Holler wrote:
>
>> I wonder how many people believe that either there will be another
>> DockStar with the same HW and GPIOs for the LEDs but more memory (and
>> still without sata) or that there will be another SheevaPlug with just
>> 128MB RAM or that someone could have a reason to change the memory
>> layout using a mem= parameter.
>>
>> For me all that is pretty unlikely.
>
> As Nicolas stated it's not just about "Oh, thats totally unlikely to
> happen!". It is about maintainable code, if somebody looks at it in 3
> years they should not think "WTF?!?!". Using machine ids and the
> generated macros helps to keep the code clean and readable.
Sorry, I can't agree. For me some unique hardware identifier is more
reasonable, than some machine id which comes from outerspace.
And in no way I see any argument for that "clean and readable", at least
not in the patch I posted.
Anyway, I leave this discussion and wish all a nice day.
Regards,
Alexander
next prev parent reply other threads:[~2011-04-07 9:44 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-06 20:35 [PATCH 0/2] ARM: Unify setup for Marvell SheevaPlugs and Seagate DockStars Alexander Holler
2011-04-06 20:35 ` [PATCH 1/2] ARM: Differentiate SheevaPlugs and DockStars on the basis of the memory size Alexander Holler
2011-04-06 21:44 ` Nicolas Pitre
2011-04-06 22:45 ` Alexander Holler
2011-04-06 23:01 ` Nicolas Pitre
2011-04-06 23:22 ` Alexander Holler
2011-04-07 2:55 ` Nicolas Pitre
2011-04-07 8:55 ` Alexander Clouter
2011-04-07 21:31 ` Alexander Holler
2011-04-07 21:44 ` Alexander Clouter
2011-04-07 21:59 ` Alexander Holler
2011-04-07 22:08 ` Russell King - ARM Linux
2011-04-07 23:04 ` Alexander Holler
2011-04-08 7:24 ` Russell King - ARM Linux
2011-04-08 8:38 ` Alexander Holler
2011-04-09 8:29 ` Bernd Petrovitsch
2011-04-10 18:14 ` Alexander Holler
2011-04-10 19:29 ` Alexander Holler
2011-04-06 23:23 ` Eric Cooper
2011-04-06 20:35 ` [PATCH 2/2] ARM: Remove machine type dockstar (use sheevaplug instead) Alexander Holler
2011-04-06 21:02 ` Nicolas Pitre
2011-04-06 21:43 ` Alexander Holler
2011-04-06 22:50 ` [PATCH 0/2] ARM: Unify setup for Marvell SheevaPlugs and Seagate DockStars Nico Erfurth
2011-04-07 9:20 ` Alexander Holler
2011-04-07 9:37 ` Nico Erfurth
2011-04-07 9:44 ` Alexander Holler [this message]
2011-04-07 17:39 ` Russell King - ARM Linux
2011-04-08 3:38 ` Alexander Holler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D9D8762.3080207@ahsoftware.de \
--to=holler@ahsoftware.de \
--cc=ecc@cmu.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ne@erfurth.eu \
--cc=nico@fluxnic.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox