Re: [PATCH] leds: New PCEngines Alix LED driver using gpio interface

[Ed W <lists@wildgooses.com>]

On 07/04/2011 22:58, Andrew Morton wrote:
> On Sun,  6 Mar 2011 16:51:25 +0000
> kernel@wildgooses.com wrote:
>
>> From: Ed Wildgoose <kernel@wildgooses.com>
>>
>> This new driver replaces the old PCEngines Alix 2/3 LED driver with
>> a new driver that controls the LEDs through the leds-gpio driver.
>> The old driver accessed GPIOs directly, which created a conflict 
>> and prevented also loading the cs5535-gio driver to read other
>> GPIOs on the Alix board. With this new driver, both are loaded
>> and therefore it's possible to access both the LEDs and onboard GPIOs 
>>
>> This driver is based on leds-net5501.c 
>> by: Alessandro Zummo <a.zummo@towertech.it>
>> Additionally it relies on parts of the patch: 7f131cf3ed
>> by: Daniel Mack <daniel@caiaq.de> to perform detection of the Alix board
> As far as I can tell from looking at it, this driver maintains all the
> same interfaces and behaviour as the old version.  Am I right?
>

Yes, this is correct.  The substance of the change is simply to use the
leds-gpio interface rather than fiddling with gpio settings directly. 
However, please note that Grant and Andres suggested that the driver
should instead move to "arch" and out of leds? Therefore, I created an
updated version of this patch which you can find from message id:
"1300553466-23873-1-git-send-email-kernel@wildgooses.com", ie:
    http://lists.zerezo.com/linux-kernel/msg27455553.html

Additionally this updated patch has a slightly amended copyright -
several folks thought that the updated copyright statement was more
appropriate

My apologies that this updated patch was not more clearly marked as such
- Grant has taken the time to point out how I should submit patches more
clearly in the future

I would be happy to shuffle the code around further if anyone has an
opinion?

Thanks for picking this up

Ed W