From: Jiri Slaby <jirislaby@gmail.com>
To: Valdis.Kletnieks@vt.edu
Cc: Vasiliy Kulikov <segoon@openwall.com>,
linux-kernel@vger.kernel.org, Greg Kroah-Hartman <gregkh@suse.de>,
Arnd Bergmann <arnd@arndb.de>, Alan Cox <alan@linux.intel.com>
Subject: Re: [PATCH] char: istallion: fix arbitrary kernel memory reads/writes
Date: Sat, 09 Apr 2011 22:36:03 +0200 [thread overview]
Message-ID: <4DA0C333.1050300@gmail.com> (raw)
In-Reply-To: <107257.1302380698@localhost>
On 04/09/2011 10:24 PM, Valdis.Kletnieks@vt.edu wrote:
> On Sat, 09 Apr 2011 15:26:59 +0200, Jiri Slaby said:
>> On 04/09/2011 02:41 PM, Vasiliy Kulikov wrote:
>>> stli_brdstats is defined as global variable. After de-BKL-ization in
>>> the patch b4eda9cb48eac1b7 an access to the variable is not serialized
>>> anymore. This leads to the TOCTOU in stli_getbrdstats():
>>
>> Don't use such a weird and uncommon abbreviations.
>
> Time Of Check [to] Time Of Use. Hardly uncommon, especially in the security
> community.
Well, changelogs are not for security community only. And I think I've
read far than enough papers about code analysis and never seen that before.
> Googling for 'TOCTOU' and 'TOCTTOU' gets about 60K hits combined.
Sure, I googled that a bit. But that didn't persuade me at all. It looks
like it is used by a narrow set of experts.
Whatever, I mainly wanted to point out the code move.
thanks,
--
js
next prev parent reply other threads:[~2011-04-09 20:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-09 12:41 [PATCH] char: istallion: fix arbitrary kernel memory reads/writes Vasiliy Kulikov
2011-04-09 13:26 ` Jiri Slaby
2011-04-09 20:24 ` Valdis.Kletnieks
2011-04-09 20:36 ` Jiri Slaby [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-04-14 15:56 Vasiliy Kulikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DA0C333.1050300@gmail.com \
--to=jirislaby@gmail.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=alan@linux.intel.com \
--cc=arnd@arndb.de \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=segoon@openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).