public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Frederic Weisbecker <fweisbec@gmail.com>,
	Ingo Molnar <mingo@elte.hu>,
	Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
	Peter Zijlstra <peterz@infradead.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: adding trace-cmd's plugins to perf
Date: Sat, 09 Apr 2011 21:50:29 -0600	[thread overview]
Message-ID: <4DA12905.2020806@gmail.com> (raw)

Right now perf script cannot process kvm tracepoints:

perf record -e kvm:* -p 6446 -- sleep 5

perf script
  Warning: Error: expected type 4 but read 7
  Warning: Error: expected type 5 but read 0
  Warning: failed to read event print fmt for kvm_apic
  Warning: Error: expected type 4 but read 7
  Warning: Error: expected type 5 but read 0
  Warning: failed to read event print fmt for kvm_inj_exception
  Fatal: bad op token {

trace-cmd can parse the events through the kvm plugin.

As I understand it trace-cmd and perf have a lot of similar code, so I
would expect to be able to add the plugin capability to perf somewhat
easily. However, that does not seem to be the right thing to do (copying
yet more code between the two).

Before I invest a lot of time on this path I figured I should ask what
the intentions (roadmap seems to be too formal a word ;-)) are about
merging common code between the two commands. Also, trace-cmd and perf
are in separate repositories so a shared lib is going to inconvenience
one of the two.

Thanks,
David

             reply	other threads:[~2011-04-10  3:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-10  3:50 David Ahern [this message]
2011-04-12 16:22 ` adding trace-cmd's plugins to perf Frederic Weisbecker
2011-04-12 18:35   ` Arnaldo Carvalho de Melo
2011-04-12 18:51     ` Borislav Petkov
2011-04-12 18:56       ` Arnaldo Carvalho de Melo
2011-04-12 19:01         ` Borislav Petkov
2011-04-12 19:39           ` David Ahern
2011-04-12 20:01             ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DA12905.2020806@gmail.com \
    --to=dsahern@gmail.com \
    --cc=acme@ghostprotocols.net \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox