From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756887Ab1DMOpm (ORCPT ); Wed, 13 Apr 2011 10:45:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38863 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756363Ab1DMOpl (ORCPT ); Wed, 13 Apr 2011 10:45:41 -0400 Message-ID: <4DA5B708.6020004@redhat.com> Date: Wed, 13 Apr 2011 10:45:28 -0400 From: Prarit Bhargava User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.9) Gecko/20100505 Fedora/3.0.4-2.el6 Thunderbird/3.0.4 MIME-Version: 1.0 To: Borislav Petkov CC: "linux-kernel@vger.kernel.org" , Russ Anderson , "Luck, Tony" , "dzickus@redhat.com" , "mstowe@redhat.com" , "dnelson@redhat.com" , "rja@americas.sgi.com" Subject: Re: [PATCH 2/3] x86, MCE: Drop default decoding notifier References: <20110413132409.GB1900@gere.osrc.amd.com> <1302701810-2471-2-git-send-email-bp@amd64.org> <4DA5ACB2.1070505@redhat.com> <20110413141829.GE1987@aftab> <4DA5B1B1.5090905@redhat.com> <20110413142648.GB2791@aftab> <4DA5B403.2010203@redhat.com> <20110413143917.GD2791@aftab> In-Reply-To: <20110413143917.GD2791@aftab> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/13/2011 10:39 AM, Borislav Petkov wrote: > On Wed, Apr 13, 2011 at 10:32:35AM -0400, Prarit Bhargava wrote: > >> >>>> .. right ... but we would still see nonsensical messages before the >>>> panic, which will confuse the end user. IMO, dump the messages unless >>>> it's UC. And we shouldn't print out the human readable message at all. >>>> >>>> >>> I'd still leave the "mcelog ... " line though as a hint. >>> >>> >>> >> :) >> >> There are no messages -- that's part of the problem. We're asking a >> user to do something for a message that doesn't exist ... >> > Yes and no - in the UC case you get all the MCA registers dumped in > print_mce() - and those you want to decode. In the CE case, we won't be > issuing any with the default notifier removed. I just sent you a -v2, I > think it should do what we want. > Yup. > Or am I missing something...? > > Nope. The follow up looks great :) P. > Thanks. > >