[PATCH] usb: Fix Kconfig unmet dependencies for Microblaze EHCI

[PATCH] usb: Fix Kconfig unmet dependencies for Microblaze EHCI

[Michal Simek]

Disable USB_ARCH_HAS_EHCI in arch Kconfig and enable it in usb Kconfig

Warning log:
warning: (LOCKDEP && FAULT_INJECTION_STACKTRACE_FILTER && LATENCYTOP && FUNCTION_TRACER &&
KMEMCHECK) selects FRAME_POINTER which has unmet direct dependencies (DEBUG_KERNEL &&
(CRIS || M68K || FRV || UML || AVR32 || SUPERH || BLACKFIN || MN10300) ||
ARCH_WANT_FRAME_POINTERS)

Signed-off-by: Michal Simek <monstr@monstr.eu>
CC: Greg Kroah-Hartman <gregkh@suse.de>
CC: linux-usb@vger.kernel.org
---
 arch/microblaze/Kconfig |    1 -
 drivers/usb/Kconfig     |    1 +
 2 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/microblaze/Kconfig b/arch/microblaze/Kconfig
index c49c326..46b970e 100644
--- a/arch/microblaze/Kconfig
+++ b/arch/microblaze/Kconfig
@@ -6,7 +6,6 @@ config MICROBLAZE
 	select HAVE_FUNCTION_GRAPH_TRACER
 	select HAVE_DYNAMIC_FTRACE
 	select HAVE_FTRACE_MCOUNT_RECORD
-	select USB_ARCH_HAS_EHCI
 	select ARCH_WANT_OPTIONAL_GPIOLIB
 	select HAVE_OPROFILE
 	select HAVE_ARCH_KGDB
diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig
index 41b6e51..006489d 100644
--- a/drivers/usb/Kconfig
+++ b/drivers/usb/Kconfig
@@ -66,6 +66,7 @@ config USB_ARCH_HAS_EHCI
 	default y if ARCH_VT8500
 	default y if PLAT_SPEAR
 	default y if ARCH_MSM
+	default y if MICROBLAZE
 	default PCI
 
 # ARM SA1111 chips have a non-PCI based "OHCI-compatible" USB host interface.
-- 
1.5.5.6

[PATCH] ftrace: Build without frame pointers on Microblaze

[Michal Simek]

Microblaze doesn't need/support FRAME_POINTERS in order to have a working
function tracer.

The patch remove Kconfig warning.

Warning log:
warning: (LOCKDEP && FAULT_INJECTION_STACKTRACE_FILTER && LATENCYTOP &&
FUNCTION_TRACER && KMEMCHECK) selects FRAME_POINTER which has unmet direct
dependencies (DEBUG_KERNEL && (CRIS || M68K || FRV || UML || AVR32 ||
SUPERH || BLACKFIN || MN10300) || ARCH_WANT_FRAME_POINTERS)

Signed-off-by: Michal Simek <monstr@monstr.eu>
CC: Steven Rostedt <rostedt@goodmis.org>
CC: Frederic Weisbecker <fweisbec@gmail.com>
CC: Ingo Molnar <mingo@redhat.com>
---
 kernel/trace/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
index 61d7d59..2ad39e5 100644
--- a/kernel/trace/Kconfig
+++ b/kernel/trace/Kconfig
@@ -141,7 +141,7 @@ if FTRACE
 config FUNCTION_TRACER
 	bool "Kernel Function Tracer"
 	depends on HAVE_FUNCTION_TRACER
-	select FRAME_POINTER if !ARM_UNWIND && !S390
+	select FRAME_POINTER if !ARM_UNWIND && !S390 && !MICROBLAZE
 	select KALLSYMS
 	select GENERIC_TRACER
 	select CONTEXT_SWITCH_TRACER
-- 
1.5.5.6

Re: [PATCH] ftrace: Build without frame pointers on Microblaze

[Michal Simek]

Hi Ingo, [cc: Steven and Frederic]

can you please add this patch to your tree?

Thanks,
Michal

Michal Simek wrote:
> Microblaze doesn't need/support FRAME_POINTERS in order to have a working
> function tracer.
> 
> The patch remove Kconfig warning.
> 
> Warning log:
> warning: (LOCKDEP && FAULT_INJECTION_STACKTRACE_FILTER && LATENCYTOP &&
> FUNCTION_TRACER && KMEMCHECK) selects FRAME_POINTER which has unmet direct
> dependencies (DEBUG_KERNEL && (CRIS || M68K || FRV || UML || AVR32 ||
> SUPERH || BLACKFIN || MN10300) || ARCH_WANT_FRAME_POINTERS)
> 
> Signed-off-by: Michal Simek <monstr@monstr.eu>
> CC: Steven Rostedt <rostedt@goodmis.org>
> CC: Frederic Weisbecker <fweisbec@gmail.com>
> CC: Ingo Molnar <mingo@redhat.com>
> ---
>  kernel/trace/Kconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
> index 61d7d59..2ad39e5 100644
> --- a/kernel/trace/Kconfig
> +++ b/kernel/trace/Kconfig
> @@ -141,7 +141,7 @@ if FTRACE
>  config FUNCTION_TRACER
>  	bool "Kernel Function Tracer"
>  	depends on HAVE_FUNCTION_TRACER
> -	select FRAME_POINTER if !ARM_UNWIND && !S390
> +	select FRAME_POINTER if !ARM_UNWIND && !S390 && !MICROBLAZE
>  	select KALLSYMS
>  	select GENERIC_TRACER
>  	select CONTEXT_SWITCH_TRACER


-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian

Re: [PATCH] ftrace: Build without frame pointers on Microblaze

[Steven Rostedt]

On Thu, 2011-04-14 at 08:48 +0200, Michal Simek wrote:
> Hi Ingo, [cc: Steven and Frederic]
> 
> can you please add this patch to your tree?
> 

Sorry, I've been traveling and I'm behind on email. I'll queue this up.
Is this needed for 2.6.39 or can it wait to 2.6.40?

-- Steve

Re: [PATCH] ftrace: Build without frame pointers on Microblaze

[Michal Simek]

Steven Rostedt wrote:
> On Thu, 2011-04-14 at 08:48 +0200, Michal Simek wrote:
>> Hi Ingo, [cc: Steven and Frederic]
>>
>> can you please add this patch to your tree?
>>
> 
> Sorry, I've been traveling and I'm behind on email. I'll queue this up.
> Is this needed for 2.6.39 or can it wait to 2.6.40?

No problem. It is fix and it could go to 2.6.39. But it is up to you.

Thanks,
Michal



-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian

[tip:perf/urgent] ftrace: Build without frame pointers on Microblaze

[tip-bot for Michal Simek]

Commit-ID:  d20ac252821ab9780ddf00b95629547d3cebc857
Gitweb:     http://git.kernel.org/tip/d20ac252821ab9780ddf00b95629547d3cebc857
Author:     Michal Simek <monstr@monstr.eu>
AuthorDate: Mon, 4 Apr 2011 11:20:12 +0200
Committer:  Steven Rostedt <rostedt@goodmis.org>
CommitDate: Thu, 21 Apr 2011 09:06:24 -0400

ftrace: Build without frame pointers on Microblaze

Microblaze doesn't need/support FRAME_POINTERS in order to have a working
function tracer.

The patch remove Kconfig warning.

Warning log:
warning: (LOCKDEP && FAULT_INJECTION_STACKTRACE_FILTER && LATENCYTOP &&
FUNCTION_TRACER && KMEMCHECK) selects FRAME_POINTER which has unmet direct
dependencies (DEBUG_KERNEL && (CRIS || M68K || FRV || UML || AVR32 ||
SUPERH || BLACKFIN || MN10300) || ARCH_WANT_FRAME_POINTERS)

Signed-off-by: Michal Simek <monstr@monstr.eu>
Link: http://lkml.kernel.org/r/1301908812-8119-2-git-send-email-monstr@monstr.eu
CC: Frederic Weisbecker <fweisbec@gmail.com>
CC: Ingo Molnar <mingo@redhat.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
 kernel/trace/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
index 61d7d59f..2ad39e5 100644
--- a/kernel/trace/Kconfig
+++ b/kernel/trace/Kconfig
@@ -141,7 +141,7 @@ if FTRACE
 config FUNCTION_TRACER
 	bool "Kernel Function Tracer"
 	depends on HAVE_FUNCTION_TRACER
-	select FRAME_POINTER if !ARM_UNWIND && !S390
+	select FRAME_POINTER if !ARM_UNWIND && !S390 && !MICROBLAZE
 	select KALLSYMS
 	select GENERIC_TRACER
 	select CONTEXT_SWITCH_TRACER

Re: [PATCH] usb: Fix Kconfig unmet dependencies for Microblaze EHCI

[Sergei Shtylyov]

Hello.

On 04-04-2011 13:20, Michal Simek wrote:

> Disable USB_ARCH_HAS_EHCI in arch Kconfig and enable it in usb Kconfig

> Warning log:
> warning: (LOCKDEP&&  FAULT_INJECTION_STACKTRACE_FILTER&&  LATENCYTOP&&  FUNCTION_TRACER&&
> KMEMCHECK) selects FRAME_POINTER which has unmet direct dependencies (DEBUG_KERNEL&&
> (CRIS || M68K || FRV || UML || AVR32 || SUPERH || BLACKFIN || MN10300) ||
> ARCH_WANT_FRAME_POINTERS)

    Hm, what this has to do with USB_ARCH_HAS_EHCI?

> Signed-off-by: Michal Simek <monstr@monstr.eu>
> CC: Greg Kroah-Hartman <gregkh@suse.de>
> CC: linux-usb@vger.kernel.org

WBR, Sergei

Re: [PATCH] usb: Fix Kconfig unmet dependencies for Microblaze EHCI

[Michal Simek]

Sergei Shtylyov wrote:
> Hello.
> 
> On 04-04-2011 13:20, Michal Simek wrote:
> 
>> Disable USB_ARCH_HAS_EHCI in arch Kconfig and enable it in usb Kconfig
> 
>> Warning log:
>> warning: (LOCKDEP&&  FAULT_INJECTION_STACKTRACE_FILTER&&  
>> LATENCYTOP&&  FUNCTION_TRACER&&
>> KMEMCHECK) selects FRAME_POINTER which has unmet direct dependencies 
>> (DEBUG_KERNEL&&
>> (CRIS || M68K || FRV || UML || AVR32 || SUPERH || BLACKFIN || MN10300) ||
>> ARCH_WANT_FRAME_POINTERS)
> 
>    Hm, what this has to do with USB_ARCH_HAS_EHCI?

aaah. c&p error. I was doing two patches and copy the same warning to both.

There should be:
warning: (MICROBLAZE) selects USB_ARCH_HAS_EHCI which has unmet direct 
dependencies (USB_SUPPORT)

Will replace it!

Thanks,
Michal




-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian