From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: "Voss, Nikolaus" <N.Voss@weinmann.de>
Cc: "'Linux Kernel'" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers/spi/atmel_spi.c: prevent premature irqs
Date: Mon, 18 Apr 2011 10:29:16 +0200 [thread overview]
Message-ID: <4DABF65C.5070607@atmel.com> (raw)
In-Reply-To: <EF2E73589CA71846A15D0B2CDF79505D086F9314A4@wm021.weinmann.com>
Le 11/04/2011 11:38, Voss, Nikolaus :
> Hi,
>
>> What about something like this?
>>
>> /* disable all interrupts to avoid premature irq triggering */
>> spi_writel(as, IDR, 0xffffffff);
>
> I implemented it this way the first time, but on a second approach I used
> the more specific variant.
>
> That way it is kept symmetric to the irq enable part in the transfer method
> which enables no more than the irqs disabled in my patch. And I generally
> feel better when not writing live values to don't care bits ;-).
That makes sense. I add my ACK.
Bye,
--
Nicolas Ferre
next prev parent reply other threads:[~2011-04-18 8:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-11 6:53 [PATCH] drivers/spi/atmel_spi.c: prevent premature irqs Voss, Nikolaus
2011-04-11 8:50 ` Nicolas Ferre
2011-04-11 9:38 ` Voss, Nikolaus
2011-04-18 8:29 ` Nicolas Ferre [this message]
2011-04-18 8:29 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DABF65C.5070607@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=N.Voss@weinmann.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox