Re: [PATCH] block: add blk_run_queue_async

Jens Axboe
2011-04-18T20:01:35Z

On 2011-04-18 21:59, Christoph Hellwig wrote:
> On Mon, Apr 18, 2011 at 03:55:04PM -0400, Mike Snitzer wrote:
>>> +{
>>> + ? ? ? if (likely(!blk_queue_stopped(q)))
>>> + ? ? ? ? ? ? ? queue_delayed_work(kblockd_workqueue, &q->delay_work, 0);
>>
>> I know Jens already queued this up 'for-linus' but why not use
>> kblockd_schedule_work(q, &q->delay_work)?
>
> I don't see what that would buy us. If we'd absolutely want a wrapper
> a blk_delay_queue(q, 0) in Jens' current tree would do it now that is
> has been fixed up to use the kblockd workqueue.

I thought about changing it to use that, but I don't think there's any
point in doing that to be honest.

--
Jens Axboe