From: "H. Peter Anvin" <hpa@zytor.com>
To: Joerg Roedel <joro@8bytes.org>
Cc: "Roedel, Joerg" <Joerg.Roedel@amd.com>,
Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Yinghai Lu <yinghai@kernel.org>
Subject: Re: [PATCH 1/4] x86, gart: Don't enforce GART aperture lower-bound by alignment
Date: Mon, 18 Apr 2011 10:39:05 -0700 [thread overview]
Message-ID: <4DAC7739.2060100@zytor.com> (raw)
In-Reply-To: <20110418173655.GA8155@8bytes.org>
On 04/18/2011 10:36 AM, Joerg Roedel wrote:
>>
>> The right thing to do for in-place kexec it to turn it off, not rely on
>> any specific magic addresses. We have had this problem with a number of
>> drivers in the context of kexec.
>
> Ok, so changing the start-address to zero seems the best thing to do.
> This way the GART will working again on machines with less than 512MB of
> RAM (and a BIOS that does not initialize the GART as we want it).
>
I'm going to apply your patch as-is, based on the notion that this is a
change of mechanism, and a change of policy is a separate thing.
However, we should address the shutdown of the GART first, and then we
can move the start address to zero (again, two separate patches.)
-hpa
next prev parent reply other threads:[~2011-04-18 17:39 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-18 13:45 [PATCH 0/4] gart cleanups and fixes Joerg Roedel
2011-04-18 13:45 ` [PATCH 1/4] x86, gart: Don't enforce GART aperture lower-bound by alignment Joerg Roedel
2011-04-18 14:45 ` H. Peter Anvin
2011-04-18 14:56 ` Roedel, Joerg
2011-04-18 15:51 ` H. Peter Anvin
2011-04-18 17:36 ` Joerg Roedel
2011-04-18 17:39 ` H. Peter Anvin [this message]
2011-04-18 17:50 ` Joerg Roedel
2011-04-18 19:06 ` Joerg Roedel
2011-04-18 19:40 ` H. Peter Anvin
2011-04-18 18:29 ` Yinghai Lu
2011-04-18 18:39 ` [tip:x86/gart] " tip-bot for Joerg Roedel
2011-04-18 13:45 ` [PATCH 2/4] x86, gart: Convert spaces to tabs in enable_gart_translation Joerg Roedel
2011-04-18 16:39 ` [tip:x86/urgent] " tip-bot for Joerg Roedel
2011-04-18 13:45 ` [PATCH 3/4] x86, gart: Set DISTLBWALKPRB bit always Joerg Roedel
2011-04-18 16:40 ` [tip:x86/urgent] " tip-bot for Joerg Roedel
2011-04-18 13:45 ` [PATCH 4/4] x86, gart: Make sure GART does not map physmem above 1TB Joerg Roedel
2011-04-18 14:46 ` H. Peter Anvin
2011-04-18 14:52 ` Roedel, Joerg
2011-04-18 15:53 ` H. Peter Anvin
2011-04-18 14:54 ` H. Peter Anvin
2011-04-18 14:59 ` Roedel, Joerg
2011-04-18 15:50 ` Ingo Molnar
2011-04-19 6:12 ` Roedel, Joerg
2011-04-19 7:25 ` Ingo Molnar
2011-04-19 9:15 ` [PATCH] x86, gart: Rename pci-gart_64.c to amd64_gart.c Roedel, Joerg
2011-04-19 13:43 ` [PATCH 4/4] x86, gart: Make sure GART does not map physmem above 1TB H. Peter Anvin
2011-04-19 14:29 ` Roedel, Joerg
2011-04-20 17:38 ` H. Peter Anvin
2011-05-10 15:32 ` [PATCH] x86, gart: Rename pci-gart_64.c to amd_gart_64.c 1TB Roedel, Joerg
2011-04-18 16:40 ` [tip:x86/urgent] x86, gart: Make sure GART does not map physmem above 1TB tip-bot for Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DAC7739.2060100@zytor.com \
--to=hpa@zytor.com \
--cc=Joerg.Roedel@amd.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox