public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Joerg Roedel <joro@8bytes.org>
Cc: "Roedel, Joerg" <Joerg.Roedel@amd.com>,
	Ingo Molnar <mingo@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	"x86@kernel.org" <x86@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Yinghai Lu <yinghai@kernel.org>
Subject: Re: [PATCH 1/4] x86, gart: Don't enforce GART aperture lower-bound by alignment
Date: Mon, 18 Apr 2011 12:40:42 -0700	[thread overview]
Message-ID: <4DAC93BA.4030108@zytor.com> (raw)
In-Reply-To: <20110418190620.GD8155@8bytes.org>

On 04/18/2011 12:06 PM, Joerg Roedel wrote:
> On Mon, Apr 18, 2011 at 10:39:05AM -0700, H. Peter Anvin wrote:
>> I'm going to apply your patch as-is, based on the notion that this is a
>> change of mechanism, and a change of policy is a separate thing.
>> However, we should address the shutdown of the GART first, and then we
>> can move the start address to zero (again, two separate patches.)
> 
> Hmm, thinking again about this, setting the lower-bound to 0 may break
> kdump setups. The kdump kernel is then able to allocate an aperture too
> and that may use half of the memory from the kdump-system so that the
> dump-process triggers OOM.
> As it is now, the GART is automatically disabled when the BIOS doesn't
> setup it correctly and the machine has not more than 512MB of memory.
> Either we keep it as is or, with the changes suggested above, we handle
> it like soft-iotlb and don't use gart for dma-api at all when
> max_pfn is smaller than 4G.
> 

OK, kdump is no longer limited to 512 MiB and so that number is spurious
in the context of kdump.  If that is broken it is already broken.  Thus
the 512 MiB number already is looking spurious.

	-hpa

  reply	other threads:[~2011-04-18 19:41 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-18 13:45 [PATCH 0/4] gart cleanups and fixes Joerg Roedel
2011-04-18 13:45 ` [PATCH 1/4] x86, gart: Don't enforce GART aperture lower-bound by alignment Joerg Roedel
2011-04-18 14:45   ` H. Peter Anvin
2011-04-18 14:56     ` Roedel, Joerg
2011-04-18 15:51       ` H. Peter Anvin
2011-04-18 17:36         ` Joerg Roedel
2011-04-18 17:39           ` H. Peter Anvin
2011-04-18 17:50             ` Joerg Roedel
2011-04-18 19:06             ` Joerg Roedel
2011-04-18 19:40               ` H. Peter Anvin [this message]
2011-04-18 18:29   ` Yinghai Lu
2011-04-18 18:39   ` [tip:x86/gart] " tip-bot for Joerg Roedel
2011-04-18 13:45 ` [PATCH 2/4] x86, gart: Convert spaces to tabs in enable_gart_translation Joerg Roedel
2011-04-18 16:39   ` [tip:x86/urgent] " tip-bot for Joerg Roedel
2011-04-18 13:45 ` [PATCH 3/4] x86, gart: Set DISTLBWALKPRB bit always Joerg Roedel
2011-04-18 16:40   ` [tip:x86/urgent] " tip-bot for Joerg Roedel
2011-04-18 13:45 ` [PATCH 4/4] x86, gart: Make sure GART does not map physmem above 1TB Joerg Roedel
2011-04-18 14:46   ` H. Peter Anvin
2011-04-18 14:52     ` Roedel, Joerg
2011-04-18 15:53       ` H. Peter Anvin
2011-04-18 14:54     ` H. Peter Anvin
2011-04-18 14:59       ` Roedel, Joerg
2011-04-18 15:50         ` Ingo Molnar
2011-04-19  6:12           ` Roedel, Joerg
2011-04-19  7:25             ` Ingo Molnar
2011-04-19  9:15               ` [PATCH] x86, gart: Rename pci-gart_64.c to amd64_gart.c Roedel, Joerg
2011-04-19 13:43               ` [PATCH 4/4] x86, gart: Make sure GART does not map physmem above 1TB H. Peter Anvin
2011-04-19 14:29                 ` Roedel, Joerg
2011-04-20 17:38                   ` H. Peter Anvin
2011-05-10 15:32                     ` [PATCH] x86, gart: Rename pci-gart_64.c to amd_gart_64.c 1TB Roedel, Joerg
2011-04-18 16:40   ` [tip:x86/urgent] x86, gart: Make sure GART does not map physmem above 1TB tip-bot for Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DAC93BA.4030108@zytor.com \
    --to=hpa@zytor.com \
    --cc=Joerg.Roedel@amd.com \
    --cc=joro@8bytes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox