From: Michal Marek <mmarek@suse.cz>
To: Haojian Zhuang <haojian.zhuang@gmail.com>
Cc: zippel@linux-m68k.org, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: LOCALVERSION in setlocalversion
Date: Tue, 19 Apr 2011 08:58:03 +0200 [thread overview]
Message-ID: <4DAD327B.4030904@suse.cz> (raw)
In-Reply-To: <BANLkTikYuYVvXiHvi_kr2H7n29k=veThtw@mail.gmail.com>
On 19.4.2011 08:42, Haojian Zhuang wrote:
> In scripts/setlocalversion under linux kernel tree, the scripts seems
> a little strange.
[...]
> # append a plus sign if the repository is not in a clean
> # annotated or signed tagged state (as git describe only
> # looks at signed or annotated tags - git tag -a/-s) and
> # LOCALVERSION= is not specified
> if test "${LOCALVERSION+set}" != "set"; then
> scm=$(scm_version --short)
> res="$res${scm:++}"
> fi
> fi
>
> LOCALVERSION isn't assigned in any place. Only CONFIG_LOCALVERSION
> can be assigned in .config file.
> Why do we need to check LOCALVERSION at here?
It can be set on the commandline:
make LOCALVERSION=something
Michal
next prev parent reply other threads:[~2011-04-19 6:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-19 6:42 LOCALVERSION in setlocalversion Haojian Zhuang
2011-04-19 6:58 ` Michal Marek [this message]
2011-04-19 7:35 ` Haojian Zhuang
2011-04-19 8:03 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DAD327B.4030904@suse.cz \
--to=mmarek@suse.cz \
--cc=haojian.zhuang@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox