From: Jack Stone <jwjstone@fastmail.fm>
To: Jiri Slaby <jslaby@suse.cz>
Cc: gregkh@suse.de, jirislaby@gmail.com,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Alan Cox <alan@linux.intel.com>
Subject: Re: [PATCH 3/7] Char: nozomi, remove useless tty_sem
Date: Wed, 20 Apr 2011 10:55:32 +0100 [thread overview]
Message-ID: <4DAEAD94.6070304@fastmail.fm> (raw)
In-Reply-To: <1303288998-31718-3-git-send-email-jslaby@suse.cz>
On 20/04/2011 09:43, Jiri Slaby wrote:
> tty_sem used to protect tty open count. This was removed in 33dd474a
> but the lock remained in place.
>
> So remove it completely as it protects nothing now.
>
> Also this solves Mac's problem with inatomic operation called from
> atomic context (ppp):
> BUG: scheduling while atomic: firefox-bin/1992/0x10000800
> Modules linked in: ...
> Pid: 1992, comm: firefox-bin Not tainted 2.6.38 #1
> Call Trace:
> ...
> [] ? mutex_lock+0xe/0x21
> [] ? ntty_write+0x5d/0x192 [nozomi]
> [] ? __mod_timer.clone.30+0xbe/0xcc
> [] ? check_preempt_curr+0x60/0x6d
> [] ? __nf_ct_refresh_acct+0x75/0xbe
> [] ? ppp_async_push+0xa9/0x3bd [ppp_async]
> [] ? ppp_async_send+0x34/0x40 [ppp_async]
> [] ? ppp_push+0x6c/0x4f9 [ppp_generic]
> ...
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Reported-by: Mac <kmac@poczta.fm>
> Tested-by: Gerald Pfeifer <gerald@pfeifer.com>
> Cc: Jack Stone <jwjstone@fastmail.fm>
Reviewed-by: Jack Stone <jwjstone@fastmail.fm>
> Cc: Alan Cox <alan@linux.intel.com>
> Cc: Greg Kroah-Hartman <gregkh@suse.de>
Thanks for sorting this Jiri.
Jack
next prev parent reply other threads:[~2011-04-20 9:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-20 8:43 [PATCH 1/7] Char: nozomi, use GFP_KERNEL for kfifo allocation Jiri Slaby
2011-04-20 8:43 ` [PATCH 2/7] Char: nozomi, remove port.count checks Jiri Slaby
2011-04-20 8:43 ` [PATCH 3/7] Char: nozomi, remove useless tty_sem Jiri Slaby
2011-04-20 9:55 ` Jack Stone [this message]
2011-04-20 8:43 ` [PATCH 4/7] Char: moxa, fix locking in moxa_write Jiri Slaby
2011-04-20 8:43 ` [PATCH 5/7] TTY: serial_core, remove invalid test Jiri Slaby
2011-04-20 8:43 ` [PATCH 6/7] TTY: serial_core, remove superfluous set_task_state Jiri Slaby
2011-04-20 8:43 ` [PATCH 7/7] TTY: tty_io, annotate locking functions Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DAEAD94.6070304@fastmail.fm \
--to=jwjstone@fastmail.fm \
--cc=alan@linux.intel.com \
--cc=gregkh@suse.de \
--cc=jirislaby@gmail.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox