public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@openvz.org>
To: Don Zickus <dzickus@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>, Lin Ming <ming.m.lin@intel.com>,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -tip] perf, x86: P4 PMU - Don't forget to clear cpuc->active_mask on overflow
Date: Thu, 21 Apr 2011 17:58:33 +0400	[thread overview]
Message-ID: <4DB03809.50806@openvz.org> (raw)
In-Reply-To: <20110421131748.GB1642@elte.hu>

On 04/21/2011 05:17 PM, Ingo Molnar wrote:
> 
> * Don Zickus <dzickus@redhat.com> wrote:
> 
>> On Wed, Apr 20, 2011 at 07:13:37PM +0400, Cyrill Gorcunov wrote:
>>> It's not enough to simply disable event on overflow the cpuc->active_mask
>>> should be cleared as well otherwise counter may stall in "active" even
>>> in real being already disabled (which potentially may lead to the situation
>>> that user may not use this counter further).
>>
>> I also noticed this patch fixed some unknown NMIs on a P4 when I stressed
>> the box
>>
>> Acked-by: Don Zickus <dzickus@redhat.com>
> 
> Ok. Mind one of you resending all pending patches in this area, with all 
> Acked-by's and Tested-by's in place?
> 
> I'd like to ask one more thing as well: please submit the patches in a single 
> e-mail thread - i.e. with a proper 0/N and e-mail threading, so that anyone can 
> see that they are a group of patches. Current submissions are various versions 
> of patches with no clear grouping.
> 
> Thanks,
> 
> 	Ingo

Don, will you pick it up in addition to your unknown NMI fast-fix?

-- 
    Cyrill

      parent reply	other threads:[~2011-04-21 13:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-20 15:13 [PATCH -tip] perf, x86: P4 PMU - Don't forget to clear cpuc->active_mask on overflow Cyrill Gorcunov
2011-04-21  6:34 ` Lin Ming
2011-04-21 12:53 ` Don Zickus
2011-04-21 13:17   ` Ingo Molnar
2011-04-21 13:57     ` Don Zickus
2011-04-21 14:00       ` Cyrill Gorcunov
2011-04-21 14:22         ` Don Zickus
2011-04-21 13:58     ` Cyrill Gorcunov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DB03809.50806@openvz.org \
    --to=gorcunov@openvz.org \
    --cc=dzickus@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.m.lin@intel.com \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox