From: Jens Axboe <axboe@kernel.dk>
To: Tejun Heo <tj@kernel.org>
Cc: Kay Sievers <kay.sievers@vrfy.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: unexport DISK_EVENT_MEDIA_CHANGE for legacy/fringe drivers
Date: Thu, 21 Apr 2011 21:31:41 +0200 [thread overview]
Message-ID: <4DB0861D.2000701@kernel.dk> (raw)
In-Reply-To: <20110421190031.GJ15988@htj.dyndns.org>
On 2011-04-21 21:00, Tejun Heo wrote:
> In-kernel disk event polling doesn't matter for legacy/fringe drivers
> and may lead to infinite event loop if ->check_events() implementation
> generates events on level condition instead of edge.
>
> Now that block layer supports suppressing exporting unlisted events,
> simply leaving disk->events cleared allows these drivers to keep the
> internal revalidation behavior intact while avoiding weird
> interactions with userland event handler.
Seems like the good thing to do, I'll queue this up for 2.6.39.
--
Jens Axboe
prev parent reply other threads:[~2011-04-21 19:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-21 19:00 [PATCH] block: unexport DISK_EVENT_MEDIA_CHANGE for legacy/fringe drivers Tejun Heo
2011-04-21 19:31 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DB0861D.2000701@kernel.dk \
--to=axboe@kernel.dk \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox