public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <jaxboe@fusionio.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Jens Axboe <axboe@kernel.dk>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.39-rc4 BUG: unable to handle kernel NULL pointer  dereference at 0000000c IP: cfq_insert_request+0x1d/0x3f5
Date: Fri, 22 Apr 2011 13:35:55 +0200	[thread overview]
Message-ID: <4DB1681B.9060208@fusionio.com> (raw)
In-Reply-To: <20110422070032.GA3575@tiehlicka.suse.cz>

On 2011-04-22 09:00, Michal Hocko wrote:
> On Thu 21-04-11 21:00:26, Jens Axboe wrote:
>> On 2011-04-21 20:51, Michal Hocko wrote:
>>> On Thu 21-04-11 07:38:57, Linus Torvalds wrote:
>>>> On Thu, Apr 21, 2011 at 12:25 AM, Jens Axboe <axboe@kernel.dk> wrote:
>>>>>>
>>>>>> I am going to bisect, let's see if I can find anything.
>>>>>
>>>>> Thanks, that would be great!
>>>>
>>>> I'd expect it to be very timing-dependent, and thus could easily be
>>>> triggered (or hidden) by unrelated changes.
>>>>
>>>> Just happening to have a request added to the elevator at _just_ the
>>>> same moment that another CPU is changing it and getting rid of the
>>>> data structures for the old one.
>>>
>>> And it really looks like a timing issue. I have bisected down to
>>> e710d7d5a9cab1041b7a3cf9e655b75d92786857. I had to skip[1] some commits
>>> due to compile errors [2].
>>> At first it looked quite promising because I was able to boot after I
>>> reverted that patch but then I have tried to revert it on top of rc4
>>> (2f666bcf757cb72549f360ef6da02f03620a48b6) and saw the same problem
>>> again.
>>>
>>> So I do not think that bisecting will help here.
>>
>> It will be timing dependent. If there's no allocated IO requests when
>> the switch happens, it'll work.
>>
>> But the commit that caused this regression is 5e84ea3a. If you revert
>> that, it should work fine. Or just apply the patch I sent (or update to
>> Linus' tree, it's in now) and it'll work as well.
> 
> Great. I can boot just fine with the current Linus tree
> (2.6.39-rc4-00149-g91e8549).
> 
> Thanks a lot!

Great, with that confirmed from you, we have no pending bugs in this
area.

-- 
Jens Axboe


  reply	other threads:[~2011-04-22 11:36 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-20 12:58 2.6.39-rc4 BUG: unable to handle kernel NULL pointer dereference at 0000000c IP: cfq_insert_request+0x1d/0x3f5 Michal Hocko
2011-04-20 13:03 ` Jens Axboe
2011-04-20 13:13 ` Jens Axboe
2011-04-20 13:29   ` Michal Hocko
2011-04-20 13:31     ` Jens Axboe
2011-04-20 17:33     ` Jens Axboe
2011-04-21  7:16       ` Michal Hocko
2011-04-21  7:25         ` Jens Axboe
2011-04-21 14:38           ` Linus Torvalds
2011-04-21 15:29             ` Jens Axboe
2011-04-21 18:52               ` Michal Hocko
2011-04-21 18:51             ` Michal Hocko
2011-04-21 19:00               ` Jens Axboe
2011-04-22  7:00                 ` Michal Hocko
2011-04-22 11:35                   ` Jens Axboe [this message]
2011-04-22 20:30                     ` Hugh Dickins
2011-04-21 15:04           ` Jeff Moyer
2011-04-21 15:27             ` Vivek Goyal
2011-04-21 15:51               ` Jeff Moyer
2011-04-21 15:30             ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DB1681B.9060208@fusionio.com \
    --to=jaxboe@fusionio.com \
    --cc=axboe@kernel.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhocko@suse.cz \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox