linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yinghai Lu <yinghai@kernel.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Chris Samuel <chris@csamuel.org>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: 2.6.38.3 and 2.6.39-rc4 hangs after "Booting the kernel" on quad Pentium Pro system
Date: Fri, 22 Apr 2011 12:46:30 -0700	[thread overview]
Message-ID: <4DB1DB16.4090100@kernel.org> (raw)
In-Reply-To: <20110422192908.GA17975@elte.hu>

On 04/22/2011 12:29 PM, Ingo Molnar wrote:
> 
> * Yinghai Lu <yinghai@kernel.org> wrote:
> 
>> with Chris's config for 2.6.39-rc4, current tip tree says:
>>
>> kernel/sched.c: In function ‘sched_init’:
>> kernel/sched.c:7845:28: error: ‘load_balance_tmpmask’ undeclared
>> (first use in this function)
>> kernel/sched.c:7845:28: note: each undeclared identifier is reported
>> only once for each function it appears in
>> kernel/sched.c:7845:3: warning: type defaults to ‘int’ in type name
>> kernel/sched.c:7845:28: warning: initialization makes pointer from
>> integer without a cast
>> kernel/sched.c:7845:3: warning: type defaults to ‘int’ in type name
> 
> Which sha1? It builds fine here on:
> 
>   ae1e16c: Merge branch 'perf/urgent'
> 

one local patch caused the problem.

Index: linux-2.6/kernel/sched.c
===================================================================
--- linux-2.6.orig/kernel/sched.c
+++ linux-2.6/kernel/sched.c
@@ -7808,9 +7808,6 @@ void __init sched_init(void)
 #ifdef CONFIG_RT_GROUP_SCHED
 	alloc_size += 2 * nr_cpu_ids * sizeof(void **);
 #endif
-#ifdef CONFIG_CPUMASK_OFFSTACK
-	alloc_size += num_possible_cpus() * cpumask_size();
-#endif
 	if (alloc_size) {
 		ptr = (unsigned long)kzalloc(alloc_size, GFP_NOWAIT);
 
@@ -7830,14 +7827,12 @@ void __init sched_init(void)
 		ptr += nr_cpu_ids * sizeof(void **);
 
 #endif /* CONFIG_RT_GROUP_SCHED */
-#ifdef CONFIG_CPUMASK_OFFSTACK
-		for_each_possible_cpu(i) {
-			per_cpu(load_balance_tmpmask, i) = (void *)ptr;
-			ptr += cpumask_size();
-		}
-#endif /* CONFIG_CPUMASK_OFFSTACK */
 	}
 
+	for_each_possible_cpu(i)
+		zalloc_cpumask_var_node(&per_cpu(load_balance_tmpmask, i),
+					GFP_NOWAIT, cpu_to_node(i));
+
 #ifdef CONFIG_SMP
 	init_defrootdomain();
 #endif


Sorry for noisy.

Thanks

Yinghai

  reply	other threads:[~2011-04-22 19:47 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-22 13:33 2.6.38.3 and 2.6.39-rc4 hangs after "Booting the kernel" on quad Pentium Pro system Chris Samuel
2011-04-22 13:46 ` Ingo Molnar
2011-04-22 19:09   ` Yinghai Lu
2011-04-22 19:29     ` Ingo Molnar
2011-04-22 19:46       ` Yinghai Lu [this message]
2011-04-23  0:20   ` Chris Samuel
2011-04-22 16:34 ` Alan Cox
2011-04-23  0:16   ` Chris Samuel
2011-04-23  1:28     ` Yuhong Bao
2011-04-23  1:35       ` Chris Samuel
2011-04-23  1:46         ` Yuhong Bao
2011-04-23  2:26           ` H. Peter Anvin
2011-04-23  2:31             ` Yuhong Bao
2011-04-23  4:33           ` Chris Samuel
2011-04-23  5:22           ` Chris Samuel
     [not found]             ` <SNT125-W25B0C502FF72465BC6B55BC3940@phx.gbl>
     [not found]               ` <201104231855.47680.chris@csamuel.org>
2011-04-23 10:47                 ` FW: " Yuhong Bao
2011-04-23 13:52                   ` Thomas Meyer
2011-04-23 17:51                     ` H. Peter Anvin
2011-04-23 23:24                     ` Chris Samuel
2011-04-24  0:16                     ` Chris Samuel
2011-04-24  0:22                       ` Chris Samuel
2011-04-24  8:46                         ` Yinghai Lu
2011-04-25 11:13                           ` Chris Samuel
2011-04-25 23:25                     ` [tip:x86/urgent] x86, setup: When probing memory with e801, use ax/bx as a pair tip-bot for H. Peter Anvin
2011-04-26  4:50                       ` Chris Samuel
2011-04-26  8:12                         ` Ingo Molnar
2011-04-27  3:30                           ` Chris Samuel
2011-05-05 11:57                           ` Chris Samuel
2011-05-05 12:10                             ` Ingo Molnar
2011-05-06 11:47                               ` Chris Samuel
2011-05-06 12:04                                 ` Ingo Molnar
2011-05-06 12:10                                   ` Chris Samuel
2011-05-30  4:54                       ` Yuhong Bao
2011-04-23  2:03       ` 2.6.38.3 and 2.6.39-rc4 hangs after "Booting the kernel" on quad Pentium Pro system H. Peter Anvin
2011-04-23  6:43         ` Chris Samuel
     [not found]     ` <1ac2dd46-0677-4be6-aca0-f8787da34cee@email.android.com>
2011-04-23  1:36       ` Chris Samuel
2011-04-23  9:35     ` Alan Cox
2011-04-23 10:35       ` Chris Samuel
2011-04-23 11:32         ` Chris Samuel
2011-04-23 13:11       ` Chris Samuel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DB1DB16.4090100@kernel.org \
    --to=yinghai@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=chris@csamuel.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).