public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arch: blackfin: use cc-cross-prefix to set CROSS_COMPILE
@ 2011-04-24 21:10 Peter Foley
  2011-04-24 21:19 ` Mike Frysinger
  0 siblings, 1 reply; 3+ messages in thread
From: Peter Foley @ 2011-04-24 21:10 UTC (permalink / raw)
  To: linux-kernel; +Cc: uclinux-dist-devel, vapier

This patch updates the blackfin Makefile to use cc-cross-prefix
to only set CROSS_COMPILE if bfin-uclinux-gcc exists.

Signed-off-by: Peter Foley <pefoley2@verizon.net>
---
 arch/blackfin/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/blackfin/Makefile b/arch/blackfin/Makefile
index 46f42b2..3f47d26 100644
--- a/arch/blackfin/Makefile
+++ b/arch/blackfin/Makefile
@@ -7,7 +7,7 @@
 #

 ifeq ($(CROSS_COMPILE),)
-CROSS_COMPILE    := bfin-uclinux-
+CROSS_COMPILE    := $(call cc-cross-prefix, bfin-uclinux-)
 endif
 LDFLAGS_vmlinux  := -X
 OBJCOPYFLAGS     := -O binary -R .note -R .comment -S
-- 
1.7.5.rc1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] arch: blackfin: use cc-cross-prefix to set CROSS_COMPILE
  2011-04-24 21:10 [PATCH] arch: blackfin: use cc-cross-prefix to set CROSS_COMPILE Peter Foley
@ 2011-04-24 21:19 ` Mike Frysinger
  2011-04-24 21:31   ` Peter Foley
  0 siblings, 1 reply; 3+ messages in thread
From: Mike Frysinger @ 2011-04-24 21:19 UTC (permalink / raw)
  To: pefoley2; +Cc: linux-kernel, uclinux-dist-devel

On Sun, Apr 24, 2011 at 17:10, Peter Foley wrote:
> This patch updates the blackfin Makefile to use cc-cross-prefix
> to only set CROSS_COMPILE if bfin-uclinux-gcc exists.

i'm not sure this is useful.  if bfin-uclinux- doesnt exist, it's
going to use the native gcc, and there is no native gcc for Blackfin
targets (since it's a nommu arch).  getting a missing bfin-uclinux-gcc
error is a lot more useful than the native compiler rejecting Blackfin
insns.
-mike

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arch: blackfin: use cc-cross-prefix to set CROSS_COMPILE
  2011-04-24 21:19 ` Mike Frysinger
@ 2011-04-24 21:31   ` Peter Foley
  0 siblings, 0 replies; 3+ messages in thread
From: Peter Foley @ 2011-04-24 21:31 UTC (permalink / raw)
  To: Mike Frysinger; +Cc: linux-kernel, uclinux-dist-devel

On 4/24/2011 5:19 PM, Mike Frysinger wrote:
> On Sun, Apr 24, 2011 at 17:10, Peter Foley wrote:
>> This patch updates the blackfin Makefile to use cc-cross-prefix
>> to only set CROSS_COMPILE if bfin-uclinux-gcc exists.
> 
> i'm not sure this is useful.  if bfin-uclinux- doesnt exist, it's
> going to use the native gcc, and there is no native gcc for Blackfin
> targets (since it's a nommu arch).  getting a missing bfin-uclinux-gcc
> error is a lot more useful than the native compiler rejecting Blackfin
> insns.
> -mike

Okay, that makes sense.

Peter

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-04-24 21:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-24 21:10 [PATCH] arch: blackfin: use cc-cross-prefix to set CROSS_COMPILE Peter Foley
2011-04-24 21:19 ` Mike Frysinger
2011-04-24 21:31   ` Peter Foley

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox