From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Anders Kaseorg <andersk@ksplice.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86, vdso: SHN_LORESERVE is an inclusive lower bound
Date: Mon, 25 Apr 2011 15:11:08 -0700 [thread overview]
Message-ID: <4DB5F17C.8040105@goop.org> (raw)
In-Reply-To: <alpine.DEB.2.02.1104251020170.26664@dr-wily.mit.edu>
On 04/25/2011 07:28 AM, Anders Kaseorg wrote:
> Test for >= SHN_LORESERVE instead of > SHN_LORESERVE.
Yep, seems reasonable. Did this cause a problem, or is it just
something you noticed?
J
> Signed-off-by: Anders Kaseorg <andersk@ksplice.com>
> ---
> arch/x86/vdso/vdso32-setup.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/vdso/vdso32-setup.c b/arch/x86/vdso/vdso32-setup.c
> index 468d591..226bfad 100644
> --- a/arch/x86/vdso/vdso32-setup.c
> +++ b/arch/x86/vdso/vdso32-setup.c
> @@ -88,7 +88,7 @@ static __init void reloc_symtab(Elf32_Ehdr *ehdr,
> sym->st_shndx == SHN_ABS)
> continue; /* skip */
>
> - if (sym->st_shndx > SHN_LORESERVE) {
> + if (sym->st_shndx >= SHN_LORESERVE) {
> printk(KERN_INFO "VDSO: unexpected st_shndx %x\n",
> sym->st_shndx);
> continue;
next prev parent reply other threads:[~2011-04-25 22:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-25 14:28 [PATCH] x86, vdso: SHN_LORESERVE is an inclusive lower bound Anders Kaseorg
2011-04-25 22:11 ` Jeremy Fitzhardinge [this message]
2011-04-25 23:18 ` Anders Kaseorg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DB5F17C.8040105@goop.org \
--to=jeremy@goop.org \
--cc=andersk@ksplice.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox