From: "H. Peter Anvin" <hpa@zytor.com>
To: Jan Beulich <JBeulich@novell.com>
Cc: mingo@elte.hu, tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: avoid pointless fields of struct cpuinfo_x86
Date: Wed, 27 Apr 2011 18:07:16 -0700 [thread overview]
Message-ID: <4DB8BDC4.508@zytor.com> (raw)
In-Reply-To: <4DB84D4C020000780003E675@vpn.id2.novell.com>
On 04/27/2011 08:07 AM, Jan Beulich wrote:
> Several of the flag fields of this structure are completely unused in
> certain (common) configurations. Don't pointlessly reserve space for
> them, and have truly flag-only fields consume a single bit only.
>
> Make functionality detection conditional upon (partly new) config
> options that are now also used to control the presence of those
> fields.
If you're going to make them bitflags, please use the features array we
already have. I do not think there is any point in compressing the
array if we're not doing something epicly wrong.
One thing I would like to see is to move the bug flags into an array
separate from the features array; the bug array should be OR'd together
(if there is a bug on any CPU, it is here) instead of AND'ed; or we
could just put them into the features array with negative logic (the
lack of a bug is a feature.)
That way we get to reuse all of our machinery.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
prev parent reply other threads:[~2011-04-28 1:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-27 15:07 [PATCH] x86: avoid pointless fields of struct cpuinfo_x86 Jan Beulich
2011-04-28 1:07 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DB8BDC4.508@zytor.com \
--to=hpa@zytor.com \
--cc=JBeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox