From: Avi Kivity <avi@redhat.com>
To: paulmck@linux.vnet.ibm.com
Cc: Gleb Natapov <gleb@redhat.com>,
linux-kernel@vger.kernel.org, mtosatti@redhat.com,
kvm@vger.kernel.org
Subject: Re: [PATCH 1/2] rcu: export rcu_note_context_switch() function
Date: Sat, 30 Apr 2011 22:43:16 +0300 [thread overview]
Message-ID: <4DBC6654.5030003@redhat.com> (raw)
In-Reply-To: <20110430125928.GJ2297@linux.vnet.ibm.com>
On 04/30/2011 03:59 PM, Paul E. McKenney wrote:
> > That will work, but does making rcu_note_context_switch() out of line
> > actually increase kernel size? The function is called in two places
> > currently, so by making it out of line we make two calling site smaller.
> > Will measure it next week.
>
> One thing to keep in mind... Calling an out-of-line function from
> KVM requires an export, each of which significantly increases TINY_RCU's
> memory footprint.
I would expect that most kvm configs will actually be smp (perhaps with
an exception for embedded ppc).
A completely random idea - how about trimming exports that aren't
actually used? so if you have a minimal setup you only get the hit if
you actually use kvm.
(The trimming would need to be optional so external modules can continue
to work for those who want them)
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
next prev parent reply other threads:[~2011-04-30 19:43 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-28 9:52 [PATCH 0/2] make kvm guest mode to be rcu quiescent state Gleb Natapov
2011-04-28 9:52 ` [PATCH 1/2] rcu: export rcu_note_context_switch() function Gleb Natapov
2011-04-28 10:01 ` Avi Kivity
2011-04-28 10:11 ` Gleb Natapov
2011-04-29 8:36 ` Paul E. McKenney
2011-04-29 8:39 ` Paul E. McKenney
2011-04-29 18:02 ` Gleb Natapov
2011-04-29 18:23 ` Gleb Natapov
2011-04-30 12:59 ` Paul E. McKenney
2011-04-30 19:43 ` Avi Kivity [this message]
2011-05-02 10:56 ` Gleb Natapov
2011-05-02 13:36 ` Paul E. McKenney
2011-05-02 14:10 ` Gleb Natapov
2011-05-03 6:25 ` Paul E. McKenney
2011-05-04 13:10 ` Gleb Natapov
2011-04-28 9:52 ` [PATCH 2/2] KVM: make guest mode entry to be rcu quiescent state Gleb Natapov
2011-05-03 13:13 ` Marcelo Tosatti
2011-05-03 13:20 ` Avi Kivity
2011-05-03 13:21 ` Gleb Natapov
2011-05-03 13:29 ` Marcelo Tosatti
2011-05-03 13:39 ` Gleb Natapov
2011-05-03 15:42 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DBC6654.5030003@redhat.com \
--to=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox