public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Corey Ashford <cjashfor@linux.vnet.ibm.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Andi Kleen <ak@linux.intel.com>,
	Pekka Enberg <penberg@kernel.org>,
	Vince Weaver <vweaver1@eecs.utk.edu>,
	torvalds@linux-foundation.org, Ingo Molnar <mingo@elte.hu>,
	linux-kernel@vger.kernel.org,
	Peter Zijlstra <peterz@infradead.org>,
	Stephane Eranian <eranian@gmail.com>,
	Carl Love <carll@us.ibm.com>
Subject: Re: re-enable Nehalem raw Offcore-Events support
Date: Sat, 30 Apr 2011 13:06:25 -0700	[thread overview]
Message-ID: <4DBC6BC1.5090102@linux.vnet.ibm.com> (raw)
In-Reply-To: <alpine.LFD.2.02.1104291938240.3005@ionos>

On 04/29/2011 10:42 AM, Thomas Gleixner wrote:
> On Fri, 29 Apr 2011, Andi Kleen wrote:
>
>>>>   2.  Users are too stupid to use the raw functionality properly;
>>>>       we should only allow a kernel-developer-approved small subset
>>>>       of the features provided by the CPU as described in the intel
>>>>       developers manuals.
>>>>
>>>> #2 seems like a gross misinterpretation of the whole "Linux gives you
>>>> enough rope to shoot yourself in the foot" policy from days passed, but
>>>> maybe things have moved on.
>>>
>>> That's a gross misrepresentation of what Ingo has been saying on LKML.
>>> Really, learn to work with relevant maintainers before you ask Linus
>>> to revert something.
>>
>> Ingo may not have explicitely said (2), but at least his revert (disabling
>> the raw interface users are asking for) is practically implementing (2).
>>
>> Actions speak louder than words.
>>
>> That is either you have a raw interface or you only have the cooked
>> interface or you have both. Since he reverted raw only cooked
>> is left, which is (2)
>>
>> I agree with Vince it's a bad policy.
>
> No, it's not the raw interface will be made available when the proper
> set of abstracted functionality has been added and settled down,
> simply because it might to change the way the raw event is exposed. As
> long there are open questions which might have an influence on the
> exposure of the raw event, it's completely correct to keep it
> disabled.

Carl Love and I recently completed some work to add perf_events support 
for the IBM Blue Waters machine's "CPU networking" chip, called the 
Torrent chip.  We did all of this work based on a RHEL 6 kernel 
(2.6.32ish), which doesn't have Peter's more recent multi-PMU support.

I would say that most if not all of the events are not generalizable in 
the sense that you are talking about; the events are very specific to 
the Torrent chip.  For example, the Torrent chip communicates with four 
POWER7 chips via a high-speed serial interconnect, called the W, X, Y, 
and Z links, and it also has similar links which connect to other 
Torrent chips, and to other nodes.  The events measure certain types of 
activity on these various links, for example "X link receive idle".

So if I'm understanding what you have said correctly, we would not be 
able to get a forward port of this code committed without abstracting 
these events in a away that's acceptable to the kernel community.  Is 
that right?  If so, this is important for us to know so that we can 
correctly size the work effort involved in the forward port.

Thanks for your consideration,

- Corey

  reply	other threads:[~2011-04-30 20:06 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-29 15:04 re-enable Nehalem raw Offcore-Events support Vince Weaver
2011-04-29 15:27 ` Andi Kleen
2011-04-29 16:49   ` Ingo Molnar
2011-04-29 16:42 ` Ingo Molnar
2011-04-29 18:01   ` Vince Weaver
2011-04-29 18:57     ` Ingo Molnar
2011-04-30  2:17       ` Vince Weaver
2011-04-30  7:14         ` Pekka Enberg
2011-04-30 20:47           ` Vince Weaver
2011-05-01 18:31             ` Ingo Molnar
2011-04-30  8:11         ` Borislav Petkov
2011-04-30 21:03           ` Vince Weaver
2011-05-09 11:01       ` stephane eranian
2011-05-10  9:35         ` Ingo Molnar
2011-04-29 22:16   ` Borislav Petkov
2011-04-30  1:49     ` Vince Weaver
2011-04-30  1:53   ` Vince Weaver
2011-04-30 20:58     ` Vince Weaver
2011-04-30 21:09       ` Alan Cox
2011-04-29 17:17 ` Pekka Enberg
2011-04-29 17:25   ` Andi Kleen
2011-04-29 17:37     ` Pekka Enberg
2011-04-29 17:46       ` Vince Weaver
2011-04-29 17:59         ` Pekka Enberg
2011-04-29 17:42     ` Thomas Gleixner
2011-04-30 20:06       ` Corey Ashford [this message]
2011-05-01  4:45         ` Andi Kleen
2011-05-01 18:00           ` Ingo Molnar
2011-05-01 17:55         ` Ingo Molnar
2011-05-02 18:32           ` Corey Ashford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DBC6BC1.5090102@linux.vnet.ibm.com \
    --to=cjashfor@linux.vnet.ibm.com \
    --cc=ak@linux.intel.com \
    --cc=carll@us.ibm.com \
    --cc=eranian@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=penberg@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=vweaver1@eecs.utk.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox