From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Suresh Siddha <suresh.b.siddha@intel.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [patch 1/2] x86, x2apic: minimize IPI register writes using cluster groups v4
Date: Mon, 02 May 2011 19:16:04 +0400 [thread overview]
Message-ID: <4DBECAB4.7020809@gmail.com> (raw)
In-Reply-To: <20110502150552.GA21974@elte.hu>
On 05/02/2011 07:05 PM, Ingo Molnar wrote:
...
>>
>> Ingo, would it be fine to make apic->init() either _before_ this series or
>> on top of them (because if I introduce it inside this particular patch it
>> would contain some unrelated code snippets such as .init = NULL for all apics
>> declaration).
>
> Of course it should be a separate patch - even this patch looks a bit large -
> any way to split it up further?
Well, for this particular path the only minimum is used, so i fear there is no
way to split it, probably I could drop some 'cleanup' bits from it and make it
a separate one. Gimme some time.
>
> And yes, if it fits it should be in apic->probe() instead of introducing a new
> ->init() method.
I'll recheck. Thanks for all comments Ingo, drop this series for a while then.
>
> Thanks,
>
> Ingo
--
Thanks,
Cyrill
next prev parent reply other threads:[~2011-05-02 15:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-02 11:34 [patch 0/2] x2apic optimization, v4 log updated Cyrill Gorcunov
2011-05-02 11:34 ` [patch 1/2] x86, x2apic: minimize IPI register writes using cluster groups v4 Cyrill Gorcunov
2011-05-02 13:22 ` Ingo Molnar
2011-05-02 14:02 ` Cyrill Gorcunov
2011-05-02 14:23 ` Cyrill Gorcunov
2011-05-02 15:05 ` Ingo Molnar
2011-05-02 15:16 ` Cyrill Gorcunov [this message]
2011-05-03 6:31 ` Ingo Molnar
2011-05-03 6:59 ` Cyrill Gorcunov
2011-05-02 18:27 ` Suresh Siddha
2011-05-02 11:34 ` [patch 2/2] x86, x2apic: Move the common bits of physical and cluster modes to x2apic.h v4 Cyrill Gorcunov
-- strict thread matches above, loose matches on Subject: below --
2011-04-30 17:14 [patch 0/2] x2apic optimization, round 4 Cyrill Gorcunov
2011-04-30 17:15 ` [patch 1/2] x86, x2apic: minimize IPI register writes using cluster groups v4 Cyrill Gorcunov
2011-05-01 17:18 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DBECAB4.7020809@gmail.com \
--to=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=suresh.b.siddha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox