From: "H. Peter Anvin" <hpa@zytor.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Hans Rosenfeld <hans.rosenfeld@amd.com>,
brgerst@gmail.com, tglx@linutronix.de, mingo@elte.hu,
suresh.b.siddha@intel.com, eranian@google.com,
robert.richter@amd.com, Andreas.Herrmann3@amd.com,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] fork: avoid weak function arch_dup_task_struct
Date: Mon, 02 May 2011 08:36:10 -0700 [thread overview]
Message-ID: <4DBECF6A.6060203@zytor.com> (raw)
In-Reply-To: <20110501171149.9a9342fc.akpm@linux-foundation.org>
On 05/01/2011 05:11 PM, Andrew Morton wrote:
> On Sun, 01 May 2011 15:59:12 -0700 "H. Peter Anvin"<hpa@zytor.com> wrote:
>
>> On 05/01/2011 12:25 PM, Andrew Morton wrote:
>>> On Wed, 27 Apr 2011 16:26:35 +0200 Hans Rosenfeld<hans.rosenfeld@amd.com> wrote:
>>>
>>>> Avoid potential gcc bug by not using a weak function for
>>>> arch_dup_task_struct. Use an #ifdef'ed static function for
>>>> archs that don't have a special arch_dup_task_struct implementation.
>>>
>>> The patch is unreviewable (and hence unusable) if you don't describe
>>> this "potential gcc bug".
>>
>> http://lkml.indiana.edu/hypermail/linux/kernel/0804.3/3202.html
>>
>
> gcc-4.1.0 and 4.1.1 were explicitly banned via a test in
> include/linux/compiler-gcc4.h for this reason.
>
OK, no issue then. Sorry for the noise.
-hpa
prev parent reply other threads:[~2011-05-02 15:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2be7032a-e4b6-4ce7-af53-532d77dbfb48@email.android.com>
2011-04-27 14:26 ` [PATCH 1/2] x86, xsave: fix non-lazy allocation of the xsave area Hans Rosenfeld
2011-04-28 5:55 ` [tip:x86/xsave] " tip-bot for Hans Rosenfeld
2011-04-27 14:26 ` [PATCH 2/2] fork: avoid weak function arch_dup_task_struct Hans Rosenfeld
2011-05-01 19:25 ` Andrew Morton
2011-05-01 22:59 ` H. Peter Anvin
2011-05-02 0:11 ` Andrew Morton
2011-05-02 15:36 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DBECF6A.6060203@zytor.com \
--to=hpa@zytor.com \
--cc=Andreas.Herrmann3@amd.com \
--cc=akpm@linux-foundation.org \
--cc=brgerst@gmail.com \
--cc=eranian@google.com \
--cc=hans.rosenfeld@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=robert.richter@amd.com \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox