* [PATCH 00/12] rtlwifi: rtl8192se: Merge new driver @ 2011-05-03 14:47 Larry Finger 2011-05-03 15:01 ` Borislav Petkov 2011-05-03 15:59 ` Walter Goldens 0 siblings, 2 replies; 15+ messages in thread From: Larry Finger @ 2011-05-03 14:47 UTC (permalink / raw) To: John W Linville; +Cc: linux-kernel, linux-wireless, chaoming_li This set of patches introduces a driver for the RTL8192SE PCI devices. The patches are as follows: 01/12: Introduce file def.h 02/12: Introduce dynamic management routines dm.c and dm.h 03/12: Introduce firmware routines fw.c and fw.h 04/12: Introduce hardware control routines hw.c and hw.h 05/12: Introduce LED routines led.c and led.h 06/12: Introduce PHY routines phy.c and phy.h 07/12: Introduce register definition header 08/12: Introduce radio control routines 09/12: Introduce main routine (sw.c and sw.h) 10/12: Introduce tables 11/12: Introduce TX/RX routines 12/12: Modify Kconfig and Makefiles to build rtl8192se Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> --- John, This material is for 2.6.40. Larry ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 00/12] rtlwifi: rtl8192se: Merge new driver 2011-05-03 14:47 [PATCH 00/12] rtlwifi: rtl8192se: Merge new driver Larry Finger @ 2011-05-03 15:01 ` Borislav Petkov 2011-05-03 20:03 ` Larry Finger 2011-05-03 15:59 ` Walter Goldens 1 sibling, 1 reply; 15+ messages in thread From: Borislav Petkov @ 2011-05-03 15:01 UTC (permalink / raw) To: Larry Finger Cc: John W Linville, linux-kernel, linux-wireless, chaoming_li, Andreas Herrmann On Tue, May 03, 2011 at 09:47:35AM -0500, Larry Finger wrote: > This set of patches introduces a driver for the RTL8192SE PCI devices. > > The patches are as follows: > > 01/12: Introduce file def.h > 02/12: Introduce dynamic management routines dm.c and dm.h > 03/12: Introduce firmware routines fw.c and fw.h > 04/12: Introduce hardware control routines hw.c and hw.h > 05/12: Introduce LED routines led.c and led.h > 06/12: Introduce PHY routines phy.c and phy.h > 07/12: Introduce register definition header > 08/12: Introduce radio control routines > 09/12: Introduce main routine (sw.c and sw.h) > 10/12: Introduce tables > 11/12: Introduce TX/RX routines > 12/12: Modify Kconfig and Makefiles to build rtl8192se I think I have such a device in my Thinkpad: 03:00.0 Network controller [0280]: Realtek Semiconductor Co., Ltd. RTL8191SEvB Wireless LAN Controller [10ec:8172] (rev 10) I could give them a run soon. Do you have them in a tree somewhere I could pull? Thanks. -- Regards/Gruss, Boris. Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach General Managers: Alberto Bozzo, Andrew Bowd Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 00/12] rtlwifi: rtl8192se: Merge new driver 2011-05-03 15:01 ` Borislav Petkov @ 2011-05-03 20:03 ` Larry Finger 2011-05-04 17:01 ` Borislav Petkov 0 siblings, 1 reply; 15+ messages in thread From: Larry Finger @ 2011-05-03 20:03 UTC (permalink / raw) To: Borislav Petkov Cc: John W Linville, linux-kernel, linux-wireless, chaoming_li, Andreas Herrmann On 05/03/2011 10:01 AM, Borislav Petkov wrote: > I think I have such a device in my Thinkpad: > > 03:00.0 Network controller [0280]: Realtek Semiconductor Co., Ltd. RTL8191SEvB Wireless LAN Controller [10ec:8172] (rev 10) > > I could give them a run soon. Do you have them in a tree somewhere I > could pull? Your device is claimed by the new driver. You can get the code from git://git.kernel.org/pub/scm/linux/kernel/git/lwfinger/rtl8192se.git This tree is based on Linville's wireless-testing tree with these 12 patches applied. Larry ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 00/12] rtlwifi: rtl8192se: Merge new driver 2011-05-03 20:03 ` Larry Finger @ 2011-05-04 17:01 ` Borislav Petkov 2011-05-04 17:20 ` Larry Finger 0 siblings, 1 reply; 15+ messages in thread From: Borislav Petkov @ 2011-05-04 17:01 UTC (permalink / raw) To: Larry Finger Cc: Borislav Petkov, John W Linville, linux-kernel, linux-wireless, chaoming_li, Andreas Herrmann On Tue, May 03, 2011 at 03:03:40PM -0500, Larry Finger wrote: > On 05/03/2011 10:01 AM, Borislav Petkov wrote: > >I think I have such a device in my Thinkpad: > > > >03:00.0 Network controller [0280]: Realtek Semiconductor Co., Ltd. RTL8191SEvB Wireless LAN Controller [10ec:8172] (rev 10) > > > >I could give them a run soon. Do you have them in a tree somewhere I > >could pull? > > Your device is claimed by the new driver. > > You can get the code from > > git://git.kernel.org/pub/scm/linux/kernel/git/lwfinger/rtl8192se.git > > This tree is based on Linville's wireless-testing tree with these 12 > patches applied. Ok, pulled, merged with mainline, built and currently using it to read mail over imap! I wish everything else in Linux worked that way :). Good job, thanks! -- Regards/Gruss, Boris. Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach General Managers: Alberto Bozzo, Andrew Bowd Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 00/12] rtlwifi: rtl8192se: Merge new driver 2011-05-04 17:01 ` Borislav Petkov @ 2011-05-04 17:20 ` Larry Finger 2011-05-04 18:06 ` Borislav Petkov 0 siblings, 1 reply; 15+ messages in thread From: Larry Finger @ 2011-05-04 17:20 UTC (permalink / raw) To: Borislav Petkov Cc: John W Linville, linux-kernel, linux-wireless, chaoming_li, Andreas Herrmann On 05/04/2011 12:01 PM, Borislav Petkov wrote: > On Tue, May 03, 2011 at 03:03:40PM -0500, Larry Finger wrote: >> On 05/03/2011 10:01 AM, Borislav Petkov wrote: >>> I think I have such a device in my Thinkpad: >>> >>> 03:00.0 Network controller [0280]: Realtek Semiconductor Co., Ltd. RTL8191SEvB Wireless LAN Controller [10ec:8172] (rev 10) >>> >>> I could give them a run soon. Do you have them in a tree somewhere I >>> could pull? >> >> Your device is claimed by the new driver. >> >> You can get the code from >> >> git://git.kernel.org/pub/scm/linux/kernel/git/lwfinger/rtl8192se.git >> >> This tree is based on Linville's wireless-testing tree with these 12 >> patches applied. > > Ok, pulled, merged with mainline, built and currently using it to read > mail over imap! I wish everything else in Linux worked that way :). > > Good job, thanks! You are very welcome. I'm glad to hear that it works for you. That driver missed the 2.6.39 merge window due to an ASPM problem that crashed my computer without any possibility of seeing what caused the blowup. I was somewhat afraid that others would get similar results even though Realsil did not see the problem. Larry ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 00/12] rtlwifi: rtl8192se: Merge new driver 2011-05-04 17:20 ` Larry Finger @ 2011-05-04 18:06 ` Borislav Petkov 2011-05-04 19:15 ` Larry Finger 0 siblings, 1 reply; 15+ messages in thread From: Borislav Petkov @ 2011-05-04 18:06 UTC (permalink / raw) To: Larry Finger Cc: Borislav Petkov, John W Linville, linux-kernel, linux-wireless, chaoming_li, Andreas Herrmann On Wed, May 04, 2011 at 12:20:37PM -0500, Larry Finger wrote: > You are very welcome. I'm glad to hear that it works for you. That > driver missed the 2.6.39 merge window due to an ASPM problem that > crashed my computer without any possibility of seeing what caused > the blowup. I was somewhat afraid that others would get similar > results even though Realsil did not see the problem. Right, so I saw the oops below while playing with the driver earlier but I attribute it to the fact that radio was switched off in the BIOS (rfkill show said "Hard blocked: yes" for the wireless device). After changing that I'm running smoothly so far. I'll keep you posted if I see anything while using it in the next weeks. Thanks. -- May 4 18:27:20 gere avahi-daemon[976]: Withdrawing workstation service for wlan0. May 4 18:27:20 gere kernel: [ 1109.575431] rtl8192se 0000:03:00.0: PCI INT A disabled May 4 18:27:27 gere kernel: [ 1116.452554] rtl8192se 0000:03:00.0: PCI INT A -> GSI 19 (level, low) -> IRQ 19 May 4 18:27:27 gere kernel: [ 1116.458855] rtl8192se 0000:03:00.0: setting latency timer to 64 May 4 18:27:27 gere kernel: [ 1116.486730] BUG: unable to handle kernel NULL pointer dereference at 0000000000000004 May 4 18:27:27 gere kernel: [ 1116.487028] IP: [<ffffffffa02fd9aa>] rtl_reg_notifier+0x3a/0xe0 [rtlwifi] May 4 18:27:27 gere kernel: [ 1116.487028] PGD 13d3f2067 PUD 13b92f067 PMD 0 May 4 18:27:27 gere kernel: [ 1116.487028] Oops: 0000 [#1] PREEMPT SMP May 4 18:27:27 gere kernel: [ 1116.487028] last sysfs file: /sys/devices/pci0000:00/0000:00:07.0/0000:03:00.0/ieee80211/phy3/uevent May 4 18:27:27 gere kernel: [ 1116.487028] CPU 1 May 4 18:27:27 gere kernel: [ 1116.487028] Modules linked in: rtl8192se(+) nls_utf8 nls_cp437 arc4 ipv6 fuse vfat fat loop btusb bluetooth usbhid snd_hda_codec_hdmi snd_hda_codec_conexant snd_hda_intel option usb_wwan usb_storage snd_hda_codec snd_hwdep snd_pcm usbserial thinkpad_acpi snd_seq snd_timer ohci_hcd snd_seq_device snd pcspkr ehci_hcd rtlwifi soundcore thermal nvram snd_page_alloc usbcore edac_core video processor evdev mac80211 ac thermal_sys cfg80211 battery rfkill k8temp button i2c_piix4 [last unloaded: rtl8192se] May 4 18:27:27 gere kernel: [ 1116.523056] May 4 18:27:27 gere kernel: [ 1116.523056] Pid: 2387, comm: modprobe Not tainted 2.6.39-rc5-wl+ #15 LENOVO 01972NG/INVALID May 4 18:27:27 gere kernel: [ 1116.523056] RIP: 0010:[<ffffffffa02fd9aa>] [<ffffffffa02fd9aa>] rtl_reg_notifier+0x3a/0xe0 [rtlwifi] May 4 18:27:27 gere kernel: [ 1116.523056] RSP: 0018:ffff88013d1a3b18 EFLAGS: 00010246 May 4 18:27:27 gere kernel: [ 1116.523056] RAX: ffff88013d211be0 RBX: ffff88013d210180 RCX: 00000000000001a0 May 4 18:27:27 gere kernel: [ 1116.523056] RDX: 000000000000000d RSI: 0000000000000000 RDI: 0000000000000000 May 4 18:27:27 gere kernel: [ 1116.523056] RBP: ffff88013d1a3b28 R08: 00000000000009bc R09: 0000000000000994 May 4 18:27:27 gere kernel: [ 1116.523056] R10: 000000000000000e R11: ffffffffa03077f4 R12: 0000000000000000 May 4 18:27:27 gere kernel: [ 1116.523056] R13: ffff88013d210180 R14: 0000000000000000 R15: 0000000000000001 May 4 18:27:27 gere kernel: [ 1116.523056] FS: 00007f6219dbb700(0000) GS:ffff88013fd00000(0000) knlGS:0000000000000000 May 4 18:27:27 gere kernel: [ 1116.523056] CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b May 4 18:27:27 gere kernel: [ 1116.523056] CR2: 0000000000000004 CR3: 000000013d3e7000 CR4: 00000000000006e0 May 4 18:27:27 gere kernel: [ 1116.523056] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 May 4 18:27:27 gere kernel: [ 1116.523056] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400 May 4 18:27:27 gere kernel: [ 1116.523056] Process modprobe (pid: 2387, threadinfo ffff88013d1a2000, task ffff88013b945eb0) May 4 18:27:27 gere kernel: [ 1116.523056] Stack: May 4 18:27:27 gere kernel: [ 1116.523056] 0000000000000000 0000000000000031 ffff88013d1a3b98 ffffffffa003d134 May 4 18:27:27 gere kernel: [ 1116.523056] ffffffffa00584c0 0000000000000000 0000000000000002 ffffffff00000000 May 4 18:27:27 gere kernel: [ 1116.523056] ffffea0004521d50 000000009552559e ffff88013e4010d0 ffff88013d210180 May 4 18:27:27 gere kernel: [ 1116.523056] Call Trace: May 4 18:27:27 gere kernel: [ 1116.523056] [<ffffffffa003d134>] wiphy_update_regulatory+0x324/0x510 [cfg80211] May 4 18:27:27 gere kernel: [ 1116.523056] [<ffffffffa003a0ac>] wiphy_register+0x1cc/0x340 [cfg80211] May 4 18:27:27 gere kernel: [ 1116.523056] [<ffffffff811052cf>] ? __kmalloc+0x11f/0x1d0 May 4 18:27:27 gere kernel: [ 1116.523056] [<ffffffffa009c31d>] ieee80211_register_hw+0x18d/0x530 [mac80211] May 4 18:27:27 gere kernel: [ 1116.523056] [<ffffffffa0303a1b>] rtl_pci_probe+0x1773/0x19ef [rtlwifi] May 4 18:27:27 gere kernel: [ 1116.523056] [<ffffffff811e3e2f>] local_pci_probe+0x5f/0xd0 May 4 18:27:27 gere kernel: [ 1116.523056] [<ffffffff811e44f8>] pci_device_probe+0x88/0xb0 May 4 18:27:27 gere kernel: [ 1116.523056] [<ffffffff8135419a>] ? driver_sysfs_add+0x7a/0xb0 May 4 18:27:27 gere kernel: [ 1116.523056] [<ffffffff81354496>] driver_probe_device+0x96/0x1b0 May 4 18:27:27 gere kernel: [ 1116.523056] [<ffffffff81354653>] __driver_attach+0xa3/0xb0 May 4 18:27:27 gere kernel: [ 1116.523056] [<ffffffff813545b0>] ? driver_probe_device+0x1b0/0x1b0 May 4 18:27:27 gere kernel: [ 1116.523056] [<ffffffff8135347e>] bus_for_each_dev+0x5e/0x90 May 4 18:27:27 gere kernel: [ 1116.523056] [<ffffffff8135411e>] driver_attach+0x1e/0x20 May 4 18:27:27 gere kernel: [ 1116.523056] [<ffffffff81353c95>] bus_add_driver+0xc5/0x270 May 4 18:27:27 gere kernel: [ 1116.523056] [<ffffffffa0097000>] ? 0xffffffffa0096fff May 4 18:27:27 gere kernel: [ 1116.523056] [<ffffffff81354c26>] driver_register+0x76/0x140 May 4 18:27:27 gere kernel: [ 1116.523056] [<ffffffffa0097000>] ? 0xffffffffa0096fff May 4 18:27:27 gere kernel: [ 1116.523056] [<ffffffff811e4796>] __pci_register_driver+0x56/0xd0 May 4 18:27:27 gere kernel: [ 1116.523056] [<ffffffffa0097023>] rtl92se_module_init+0x23/0x59 [rtl8192se] May 4 18:27:27 gere kernel: [ 1116.523056] [<ffffffff810002d4>] do_one_initcall+0x44/0x180 May 4 18:27:27 gere kernel: [ 1116.523056] [<ffffffff8108242a>] sys_init_module+0xba/0x200 May 4 18:27:27 gere kernel: [ 1116.523056] [<ffffffff8147536b>] system_call_fastpath+0x16/0x1b May 4 18:27:27 gere kernel: [ 1116.523056] Code: 24 08 66 66 66 66 90 48 89 fb 49 89 f4 e8 7f d5 db ff 48 8b 40 38 f6 80 8b 27 00 00 08 75 49 48 8b bb 90 00 00 00 e8 96 fc ff ff May 4 18:27:27 gere kernel: <41>[ 1116.523056] 83 7c 24 04 03 74 0e 31 c0 48 8b 1c 24 4c 8b 64 24 08 c9 c3 May 4 18:27:27 gere kernel: [ 1116.523056] RIP [<ffffffffa02fd9aa>] rtl_reg_notifier+0x3a/0xe0 [rtlwifi] May 4 18:27:27 gere kernel: [ 1116.523056] RSP <ffff88013d1a3b18> May 4 18:27:27 gere kernel: [ 1116.523056] CR2: 0000000000000004 May 4 18:27:27 gere kernel: [ 1116.524232] ---[ end trace 9da2e30d01853e47 ]--- -- Regards/Gruss, Boris. Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach General Managers: Alberto Bozzo, Andrew Bowd Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 00/12] rtlwifi: rtl8192se: Merge new driver 2011-05-04 18:06 ` Borislav Petkov @ 2011-05-04 19:15 ` Larry Finger 0 siblings, 0 replies; 15+ messages in thread From: Larry Finger @ 2011-05-04 19:15 UTC (permalink / raw) To: Borislav Petkov Cc: John W Linville, linux-kernel, linux-wireless, chaoming_li, Andreas Herrmann On 05/04/2011 01:06 PM, Borislav Petkov wrote: > On Wed, May 04, 2011 at 12:20:37PM -0500, Larry Finger wrote: >> You are very welcome. I'm glad to hear that it works for you. That >> driver missed the 2.6.39 merge window due to an ASPM problem that >> crashed my computer without any possibility of seeing what caused >> the blowup. I was somewhat afraid that others would get similar >> results even though Realsil did not see the problem. > > Right, so I saw the oops below while playing with the driver earlier > but I attribute it to the fact that radio was switched off in the BIOS > (rfkill show said "Hard blocked: yes" for the wireless device). After > changing that I'm running smoothly so far. I'll keep you posted if I see > anything while using it in the next weeks. > > Thanks. Thanks for the dump. I don't think the oops was due to the wireless being switched off. It looks as if you do not have the CRDA package installed, thus the regulatory domain was not setup correctly. That is a condition I realize that I have not tested. As soon as I have a fix, I'll let you know. BTW, if my analysis is correct, this bug has been around since 2.6.37 when rtl8192ce was merged. Larry ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 00/12] rtlwifi: rtl8192se: Merge new driver 2011-05-03 14:47 [PATCH 00/12] rtlwifi: rtl8192se: Merge new driver Larry Finger 2011-05-03 15:01 ` Borislav Petkov @ 2011-05-03 15:59 ` Walter Goldens 2011-05-03 16:45 ` Larry Finger 1 sibling, 1 reply; 15+ messages in thread From: Walter Goldens @ 2011-05-03 15:59 UTC (permalink / raw) To: John W Linville, Larry Finger; +Cc: linux-kernel, linux-wireless, chaoming_li > This set of patches introduces a driver for the RTL8192SE PCI devices. Any estimates on the *SU driver? :) ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 00/12] rtlwifi: rtl8192se: Merge new driver 2011-05-03 15:59 ` Walter Goldens @ 2011-05-03 16:45 ` Larry Finger 2011-05-03 20:19 ` Gábor Stefanik 0 siblings, 1 reply; 15+ messages in thread From: Larry Finger @ 2011-05-03 16:45 UTC (permalink / raw) To: Walter Goldens; +Cc: John W Linville, linux-kernel, linux-wireless, chaoming_li On 05/03/2011 10:59 AM, Walter Goldens wrote: > >> This set of patches introduces a driver for the RTL8192SE PCI devices. > > Any estimates on the *SU driver? :) Now that rtl8192se is submitted, I will start work on the driver for the RTL8192DE devices. After that will be the RTL8191SU. It has lower priority because r8712u from staging handles those devices. It is not based on mac80211, but it works. Larry ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 00/12] rtlwifi: rtl8192se: Merge new driver 2011-05-03 16:45 ` Larry Finger @ 2011-05-03 20:19 ` Gábor Stefanik 2011-05-03 20:33 ` Larry Finger 0 siblings, 1 reply; 15+ messages in thread From: Gábor Stefanik @ 2011-05-03 20:19 UTC (permalink / raw) To: Larry Finger Cc: Walter Goldens, John W Linville, linux-kernel, linux-wireless, chaoming_li On Tue, May 3, 2011 at 6:45 PM, Larry Finger <Larry.Finger@lwfinger.net> wrote: > On 05/03/2011 10:59 AM, Walter Goldens wrote: >> >>> This set of patches introduces a driver for the RTL8192SE PCI devices. >> >> Any estimates on the *SU driver? :) > > Now that rtl8192se is submitted, I will start work on the driver for the > RTL8192DE devices. After that will be the RTL8191SU. It has lower priority > because r8712u from staging handles those devices. It is not based on > mac80211, but it works. Again, may I remind you that the preferred behavior in the Linux world is release-early, release-often? :-) > > Larry > -- > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-) ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 00/12] rtlwifi: rtl8192se: Merge new driver 2011-05-03 20:19 ` Gábor Stefanik @ 2011-05-03 20:33 ` Larry Finger 2011-05-03 20:38 ` Gábor Stefanik 0 siblings, 1 reply; 15+ messages in thread From: Larry Finger @ 2011-05-03 20:33 UTC (permalink / raw) To: Gábor Stefanik Cc: Walter Goldens, John W Linville, linux-kernel, linux-wireless, chaoming_li On 05/03/2011 03:19 PM, Gábor Stefanik wrote: > On Tue, May 3, 2011 at 6:45 PM, Larry Finger<Larry.Finger@lwfinger.net> wrote: >> On 05/03/2011 10:59 AM, Walter Goldens wrote: >>> >>>> This set of patches introduces a driver for the RTL8192SE PCI devices. >>> >>> Any estimates on the *SU driver? :) >> >> Now that rtl8192se is submitted, I will start work on the driver for the >> RTL8192DE devices. After that will be the RTL8191SU. It has lower priority >> because r8712u from staging handles those devices. It is not based on >> mac80211, but it works. > > Again, may I remind you that the preferred behavior in the Linux world > is release-early, release-often? :-) That I know, but "code first" still applies. If the comparison between rtl8192ce and rtl8192cu has any validity for the rtl8192s varieties, roughly half of this driver will be shared. In addition, we do have all the USB plumbing in place, but we are still talking about a few thousand lines of code. At last contact, Realtek has no interest in this project, thus I will be on my own. Larry ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 00/12] rtlwifi: rtl8192se: Merge new driver 2011-05-03 20:33 ` Larry Finger @ 2011-05-03 20:38 ` Gábor Stefanik 2011-05-03 20:56 ` Larry Finger 0 siblings, 1 reply; 15+ messages in thread From: Gábor Stefanik @ 2011-05-03 20:38 UTC (permalink / raw) To: Larry Finger Cc: Walter Goldens, John W Linville, linux-kernel, linux-wireless, chaoming_li 2011/5/3 Larry Finger <Larry.Finger@lwfinger.net>: > On 05/03/2011 03:19 PM, Gábor Stefanik wrote: >> >> On Tue, May 3, 2011 at 6:45 PM, Larry Finger<Larry.Finger@lwfinger.net> >> wrote: >>> >>> On 05/03/2011 10:59 AM, Walter Goldens wrote: >>>> >>>>> This set of patches introduces a driver for the RTL8192SE PCI devices. >>>> >>>> Any estimates on the *SU driver? :) >>> >>> Now that rtl8192se is submitted, I will start work on the driver for the >>> RTL8192DE devices. After that will be the RTL8191SU. It has lower >>> priority >>> because r8712u from staging handles those devices. It is not based on >>> mac80211, but it works. >> >> Again, may I remind you that the preferred behavior in the Linux world >> is release-early, release-often? :-) > > That I know, but "code first" still applies. If the comparison between > rtl8192ce and rtl8192cu has any validity for the rtl8192s varieties, roughly > half of this driver will be shared. In addition, we do have all the USB > plumbing in place, but we are still talking about a few thousand lines of > code. At last contact, Realtek has no interest in this project, thus I will > be on my own. > > Larry I do not mean immediately submitting everything for inclusion - however, a publicly accessible Git tree would be nice. A non-rtlwifi, badly coded but functional and GPL-compatible driver is still better than having to use ndiswrapper/load a binary blob. -- Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-) ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 00/12] rtlwifi: rtl8192se: Merge new driver 2011-05-03 20:38 ` Gábor Stefanik @ 2011-05-03 20:56 ` Larry Finger 2011-05-03 21:09 ` Gábor Stefanik 0 siblings, 1 reply; 15+ messages in thread From: Larry Finger @ 2011-05-03 20:56 UTC (permalink / raw) To: Gábor Stefanik Cc: Walter Goldens, John W Linville, linux-kernel, linux-wireless, chaoming_li On 05/03/2011 03:38 PM, Gábor Stefanik wrote: > 2011/5/3 Larry Finger<Larry.Finger@lwfinger.net>: >> On 05/03/2011 03:19 PM, Gábor Stefanik wrote: >>> >>> On Tue, May 3, 2011 at 6:45 PM, Larry Finger<Larry.Finger@lwfinger.net> >>> wrote: >>>> >>>> On 05/03/2011 10:59 AM, Walter Goldens wrote: >>>>> >>>>>> This set of patches introduces a driver for the RTL8192SE PCI devices. >>>>> >>>>> Any estimates on the *SU driver? :) >>>> >>>> Now that rtl8192se is submitted, I will start work on the driver for the >>>> RTL8192DE devices. After that will be the RTL8191SU. It has lower >>>> priority >>>> because r8712u from staging handles those devices. It is not based on >>>> mac80211, but it works. >>> >>> Again, may I remind you that the preferred behavior in the Linux world >>> is release-early, release-often? :-) >> >> That I know, but "code first" still applies. If the comparison between >> rtl8192ce and rtl8192cu has any validity for the rtl8192s varieties, roughly >> half of this driver will be shared. In addition, we do have all the USB >> plumbing in place, but we are still talking about a few thousand lines of >> code. At last contact, Realtek has no interest in this project, thus I will >> be on my own. >> >> Larry > > I do not mean immediately submitting everything for inclusion - > however, a publicly accessible Git tree would be nice. A non-rtlwifi, > badly coded but functional and GPL-compatible driver is still better > than having to use ndiswrapper/load a binary blob. We are in better shape than having to use ndiswrapper or any non-GPL code. The r8712u driver in staging is for the RTL8192SU, and it works perfectly well. It just doesn't use mac80211, which is why it needs to be replaced. Larry ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 00/12] rtlwifi: rtl8192se: Merge new driver 2011-05-03 20:56 ` Larry Finger @ 2011-05-03 21:09 ` Gábor Stefanik 2011-05-03 21:35 ` Larry Finger 0 siblings, 1 reply; 15+ messages in thread From: Gábor Stefanik @ 2011-05-03 21:09 UTC (permalink / raw) To: Larry Finger Cc: Walter Goldens, John W Linville, linux-kernel, linux-wireless, chaoming_li 2011/5/3 Larry Finger <Larry.Finger@lwfinger.net>: > On 05/03/2011 03:38 PM, Gábor Stefanik wrote: >> >> 2011/5/3 Larry Finger<Larry.Finger@lwfinger.net>: >>> >>> On 05/03/2011 03:19 PM, Gábor Stefanik wrote: >>>> >>>> On Tue, May 3, 2011 at 6:45 PM, Larry Finger<Larry.Finger@lwfinger.net> >>>> wrote: >>>>> >>>>> On 05/03/2011 10:59 AM, Walter Goldens wrote: >>>>>> >>>>>>> This set of patches introduces a driver for the RTL8192SE PCI >>>>>>> devices. >>>>>> >>>>>> Any estimates on the *SU driver? :) >>>>> >>>>> Now that rtl8192se is submitted, I will start work on the driver for >>>>> the >>>>> RTL8192DE devices. After that will be the RTL8191SU. It has lower >>>>> priority >>>>> because r8712u from staging handles those devices. It is not based on >>>>> mac80211, but it works. >>>> >>>> Again, may I remind you that the preferred behavior in the Linux world >>>> is release-early, release-often? :-) >>> >>> That I know, but "code first" still applies. If the comparison between >>> rtl8192ce and rtl8192cu has any validity for the rtl8192s varieties, >>> roughly >>> half of this driver will be shared. In addition, we do have all the USB >>> plumbing in place, but we are still talking about a few thousand lines of >>> code. At last contact, Realtek has no interest in this project, thus I >>> will >>> be on my own. >>> >>> Larry >> >> I do not mean immediately submitting everything for inclusion - >> however, a publicly accessible Git tree would be nice. A non-rtlwifi, >> badly coded but functional and GPL-compatible driver is still better >> than having to use ndiswrapper/load a binary blob. > > We are in better shape than having to use ndiswrapper or any non-GPL code. > The r8712u driver in staging is for the RTL8192SU, and it works perfectly > well. What about RTL8192DE? > It just doesn't use mac80211, which is why it needs to be replaced. > > Larry > -- Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-) ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 00/12] rtlwifi: rtl8192se: Merge new driver 2011-05-03 21:09 ` Gábor Stefanik @ 2011-05-03 21:35 ` Larry Finger 0 siblings, 0 replies; 15+ messages in thread From: Larry Finger @ 2011-05-03 21:35 UTC (permalink / raw) To: Gábor Stefanik Cc: Walter Goldens, John W Linville, linux-kernel, linux-wireless, chaoming_li On 05/03/2011 04:09 PM, Gábor Stefanik wrote: > 2011/5/3 Larry Finger<Larry.Finger@lwfinger.net>: >> On 05/03/2011 03:38 PM, Gábor Stefanik wrote: >>> >>> 2011/5/3 Larry Finger<Larry.Finger@lwfinger.net>: >>>> >>>> On 05/03/2011 03:19 PM, Gábor Stefanik wrote: >>>>> >>>>> On Tue, May 3, 2011 at 6:45 PM, Larry Finger<Larry.Finger@lwfinger.net> >>>>> wrote: >>>>>> >>>>>> On 05/03/2011 10:59 AM, Walter Goldens wrote: >>>>>>> >>>>>>>> This set of patches introduces a driver for the RTL8192SE PCI >>>>>>>> devices. >>>>>>> >>>>>>> Any estimates on the *SU driver? :) >>>>>> >>>>>> Now that rtl8192se is submitted, I will start work on the driver for >>>>>> the >>>>>> RTL8192DE devices. After that will be the RTL8191SU. It has lower >>>>>> priority >>>>>> because r8712u from staging handles those devices. It is not based on >>>>>> mac80211, but it works. >>>>> >>>>> Again, may I remind you that the preferred behavior in the Linux world >>>>> is release-early, release-often? :-) >>>> >>>> That I know, but "code first" still applies. If the comparison between >>>> rtl8192ce and rtl8192cu has any validity for the rtl8192s varieties, >>>> roughly >>>> half of this driver will be shared. In addition, we do have all the USB >>>> plumbing in place, but we are still talking about a few thousand lines of >>>> code. At last contact, Realtek has no interest in this project, thus I >>>> will >>>> be on my own. >>>> >>>> Larry >>> >>> I do not mean immediately submitting everything for inclusion - >>> however, a publicly accessible Git tree would be nice. A non-rtlwifi, >>> badly coded but functional and GPL-compatible driver is still better >>> than having to use ndiswrapper/load a binary blob. >> >> We are in better shape than having to use ndiswrapper or any non-GPL code. >> The r8712u driver in staging is for the RTL8192SU, and it works perfectly >> well. > > What about RTL8192DE? I'm working on that one today. If all goes well, it might make 2.6.40, but that may be a little tight on time. Publish early and often does apply here. Larry ^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2011-05-04 19:15 UTC | newest] Thread overview: 15+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-05-03 14:47 [PATCH 00/12] rtlwifi: rtl8192se: Merge new driver Larry Finger 2011-05-03 15:01 ` Borislav Petkov 2011-05-03 20:03 ` Larry Finger 2011-05-04 17:01 ` Borislav Petkov 2011-05-04 17:20 ` Larry Finger 2011-05-04 18:06 ` Borislav Petkov 2011-05-04 19:15 ` Larry Finger 2011-05-03 15:59 ` Walter Goldens 2011-05-03 16:45 ` Larry Finger 2011-05-03 20:19 ` Gábor Stefanik 2011-05-03 20:33 ` Larry Finger 2011-05-03 20:38 ` Gábor Stefanik 2011-05-03 20:56 ` Larry Finger 2011-05-03 21:09 ` Gábor Stefanik 2011-05-03 21:35 ` Larry Finger
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox