Re: [RFC 1/5] platform-drivers-x86: add support for Technologic Systems TS-5xxx detection

Greg KH
2011-04-29T23:34:30Z

On Fri, Apr 29, 2011 at 06:21:48PM -0400, Vivien Didelot wrote:
> +/proc filesystem
> +----------------
> +
> +Information about the TS board is available through the /proc/ts-sbcinfo.

Really? Why?

As you now have added a new kernel/user ABI, it must be documented in
Documentation/ABI/

Please include that in your next patch.

But first off, why a new proc file? What is it used for?

> +static int ts_sbcinfo_init_buffer(char *buf, struct ts5xxx_sbcinfo *sbcinfo)
> +{
> + char *pos = buf;
> +
> + pos += ts_addbuf(pos, "Board ID", "TS-%d", sbcinfo->board_id);
> + pos += ts_addbuf(pos, "RS485", "%s", sbcinfo->rs485 ? "yes" : "no");
> + pos += ts_addbuf(pos, "AnalogToDigital", "%s",
> + sbcinfo->adc ? "yes" : "no");
> + pos += ts_addbuf(pos, "Auto485", "%s", sbcinfo->auto485 ? "yes" : "no");
> + pos += ts_addbuf(pos, "SRAM", "%s", sbcinfo->sram ? "yes" : "no");
> + pos += ts_addbuf(pos, "External Reset", "%s",
> + sbcinfo->external_reset ? "yes" : "no");

Most of these look like they should be simple "one value per file" sysfs
files for your system. That would make things much easier on your
userspace tools to handle parsing them properly, right?

Why not do that instead?

thanks,

greg k-h