From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <htejun@gmail.com>
Cc: shaohua.li@intel.com, linux-kernel@vger.kernel.org,
linux-ide@vger.kernel.org, jaxboe@fusionio.com,
hch@infradead.org, djwong@us.ibm.com
Subject: Re: [patch v2 3/3] SATA: enable non-queueable flush flag
Date: Wed, 04 May 2011 06:29:42 -0400 [thread overview]
Message-ID: <4DC12A96.7030305@pobox.com> (raw)
In-Reply-To: <20110504085323.GB8007@htj.dyndns.org>
On 05/04/2011 04:53 AM, Tejun Heo wrote:
> On Wed, May 04, 2011 at 04:17:28PM +0800, shaohua.li@intel.com wrote:
>> @@ -3424,7 +3424,9 @@ void ata_scsi_scan_host(struct ata_port
>> sdev = __scsi_add_device(ap->scsi_host, channel, id, 0,
>> NULL);
>> if (!IS_ERR(sdev)) {
>> + struct request_queue *q = sdev->request_queue;
>> dev->sdev = sdev;
>> + blk_set_queue_flush_queueable(q, false);
>> scsi_device_put(sdev);
>> } else {
>> dev->sdev = NULL;
> Isn't ata_scsi_dev_config() better place for this?
Yes :)
prev parent reply other threads:[~2011-05-04 10:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-04 8:17 [patch v2 0/3] block: optimize flush for non-queueable flush drive shaohua.li
2011-05-04 8:17 ` [patch v2 1/3] block: add a non-queueable flush flag shaohua.li
2011-05-04 9:05 ` Tejun Heo
2011-05-04 8:17 ` [patch v2 2/3] block: hold queue if flush is running for non-queueable flush drive shaohua.li
2011-05-04 9:09 ` Tejun Heo
2011-05-04 10:42 ` Sergei Shtylyov
2011-05-04 8:17 ` [patch v2 3/3] SATA: enable non-queueable flush flag shaohua.li
2011-05-04 8:53 ` Tejun Heo
2011-05-04 10:29 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC12A96.7030305@pobox.com \
--to=jgarzik@pobox.com \
--cc=djwong@us.ibm.com \
--cc=hch@infradead.org \
--cc=htejun@gmail.com \
--cc=jaxboe@fusionio.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox