public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tao Ma <tm@tao.ma>
To: linux-kernel@vger.kernel.org
Cc: axboe@kernel.dk
Subject: Re: [PATCH] block: Remove 'plug/unplug' comment in blk_execute_rq_nowait.
Date: Thu, 05 May 2011 23:59:31 +0800	[thread overview]
Message-ID: <4DC2C963.3040502@tao.ma> (raw)
In-Reply-To: <1303746918-11097-1-git-send-email-tm@tao.ma>

Jens,
	Is it ok to be merged?
On 04/25/2011 11:55 PM, Tao Ma wrote:
> From: Tao Ma <boyu.mt@taobao.com>
> 
> unplug is replaced with blk_run_queue now in blk_execute_rq_nowait,
> so change the comment accordingly.
> 
> Signed-off-by: Tao Ma <boyu.mt@taobao.com>
> ---
>  block/blk-exec.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/block/blk-exec.c b/block/blk-exec.c
> index 81e3181..d36bfbb 100644
> --- a/block/blk-exec.c
> +++ b/block/blk-exec.c
> @@ -56,7 +56,7 @@ void blk_execute_rq_nowait(struct request_queue *q, struct gendisk *bd_disk,
>  	spin_lock_irq(q->queue_lock);
>  	__elv_add_request(q, rq, where);
>  	__blk_run_queue(q);
> -	/* the queue is stopped so it won't be plugged+unplugged */
> +	/* the queue is stopped so it won't be runned */
>  	if (rq->cmd_type == REQ_TYPE_PM_RESUME)
>  		q->request_fn(q);
>  	spin_unlock_irq(q->queue_lock);


  reply	other threads:[~2011-05-05 15:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-25 15:55 [PATCH] block: Remove 'plug/unplug' comment in blk_execute_rq_nowait Tao Ma
2011-05-05 15:59 ` Tao Ma [this message]
2011-05-05 21:08   ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DC2C963.3040502@tao.ma \
    --to=tm@tao.ma \
    --cc=axboe@kernel.dk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox