* [PATCH] block: Remove 'plug/unplug' comment in blk_execute_rq_nowait.
@ 2011-04-25 15:55 Tao Ma
2011-05-05 15:59 ` Tao Ma
0 siblings, 1 reply; 3+ messages in thread
From: Tao Ma @ 2011-04-25 15:55 UTC (permalink / raw)
To: linux-kernel; +Cc: axboe
From: Tao Ma <boyu.mt@taobao.com>
unplug is replaced with blk_run_queue now in blk_execute_rq_nowait,
so change the comment accordingly.
Signed-off-by: Tao Ma <boyu.mt@taobao.com>
---
block/blk-exec.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/block/blk-exec.c b/block/blk-exec.c
index 81e3181..d36bfbb 100644
--- a/block/blk-exec.c
+++ b/block/blk-exec.c
@@ -56,7 +56,7 @@ void blk_execute_rq_nowait(struct request_queue *q, struct gendisk *bd_disk,
spin_lock_irq(q->queue_lock);
__elv_add_request(q, rq, where);
__blk_run_queue(q);
- /* the queue is stopped so it won't be plugged+unplugged */
+ /* the queue is stopped so it won't be runned */
if (rq->cmd_type == REQ_TYPE_PM_RESUME)
q->request_fn(q);
spin_unlock_irq(q->queue_lock);
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] block: Remove 'plug/unplug' comment in blk_execute_rq_nowait.
2011-04-25 15:55 [PATCH] block: Remove 'plug/unplug' comment in blk_execute_rq_nowait Tao Ma
@ 2011-05-05 15:59 ` Tao Ma
2011-05-05 21:08 ` Jens Axboe
0 siblings, 1 reply; 3+ messages in thread
From: Tao Ma @ 2011-05-05 15:59 UTC (permalink / raw)
To: linux-kernel; +Cc: axboe
Jens,
Is it ok to be merged?
On 04/25/2011 11:55 PM, Tao Ma wrote:
> From: Tao Ma <boyu.mt@taobao.com>
>
> unplug is replaced with blk_run_queue now in blk_execute_rq_nowait,
> so change the comment accordingly.
>
> Signed-off-by: Tao Ma <boyu.mt@taobao.com>
> ---
> block/blk-exec.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/block/blk-exec.c b/block/blk-exec.c
> index 81e3181..d36bfbb 100644
> --- a/block/blk-exec.c
> +++ b/block/blk-exec.c
> @@ -56,7 +56,7 @@ void blk_execute_rq_nowait(struct request_queue *q, struct gendisk *bd_disk,
> spin_lock_irq(q->queue_lock);
> __elv_add_request(q, rq, where);
> __blk_run_queue(q);
> - /* the queue is stopped so it won't be plugged+unplugged */
> + /* the queue is stopped so it won't be runned */
> if (rq->cmd_type == REQ_TYPE_PM_RESUME)
> q->request_fn(q);
> spin_unlock_irq(q->queue_lock);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] block: Remove 'plug/unplug' comment in blk_execute_rq_nowait.
2011-05-05 15:59 ` Tao Ma
@ 2011-05-05 21:08 ` Jens Axboe
0 siblings, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2011-05-05 21:08 UTC (permalink / raw)
To: Tao Ma; +Cc: linux-kernel
On 2011-05-05 09:59, Tao Ma wrote:
> Jens,
> Is it ok to be merged?
Yes, I will merge it in. I'll change the wording a little bit, it should
be 'run' not 'runned'.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-05-05 21:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-25 15:55 [PATCH] block: Remove 'plug/unplug' comment in blk_execute_rq_nowait Tao Ma
2011-05-05 15:59 ` Tao Ma
2011-05-05 21:08 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox