From: Michal Marek <mmarek@suse.cz>
To: Arun Sharma <asharma@fb.com>
Cc: linux-kbuild@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] Add $KERNELRELEASE to firmware install path
Date: Fri, 06 May 2011 12:15:21 +0200 [thread overview]
Message-ID: <4DC3CA39.30806@suse.cz> (raw)
In-Reply-To: <20110505173939.GA20575@dev1756.snc6.facebook.com>
(Adding David Woodhouse and lkml to CC, in general it's usually better
to CC topic lists in addition to lkml, rather than instead of lkml.)
On 5.5.2011 19:39, Arun Sharma wrote:
> Useful in the presence of multiple kernels with different
> firmware versions.
The changelog should also include the udev version that is able to find
the firmware there (v127, August 2008). FWIW, SUSE has been using this
patch since about that time, but we forgot to push this :-|. Anyway
Acked-by: Michal Marek <mmarek@suse.cz>
> Signed-off-by: Arun Sharma<asharma@fb.com>
>
> diff --git a/Makefile b/Makefile
> index e712243..cb715df 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -997,7 +997,7 @@ depend dep:
>
> # ---------------------------------------------------------------------------
> # Firmware install
> -INSTALL_FW_PATH=$(INSTALL_MOD_PATH)/lib/firmware
> +INSTALL_FW_PATH=$(INSTALL_MOD_PATH)/lib/firmware/$(KERNELRELEASE)
> export INSTALL_FW_PATH
>
> PHONY += firmware_install
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next parent reply other threads:[~2011-05-06 10:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110505173939.GA20575@dev1756.snc6.facebook.com>
2011-05-06 10:15 ` Michal Marek [this message]
2011-05-06 10:18 ` [PATCH] Add $KERNELRELEASE to firmware install path David Woodhouse
2011-05-06 18:44 ` Arun Sharma
2011-05-06 19:02 ` David Woodhouse
2011-05-06 22:37 ` Arun Sharma
2011-05-16 14:21 ` Michal Marek
2011-05-17 11:23 ` David Woodhouse
2011-05-17 11:37 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC3CA39.30806@suse.cz \
--to=mmarek@suse.cz \
--cc=asharma@fb.com \
--cc=dwmw2@infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox