From: viresh kumar <viresh.kumar@st.com>
To: "Koul, Vinod" <vinod.koul@intel.com>
Cc: "dan.j.williams@intel.com" <dan.j.williams@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Armando VISCONTI <armando.visconti@st.com>,
Shiraz HASHIM <shiraz.hashim@st.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"viresh.linux@gmail.com" <viresh.linux@gmail.com>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>
Subject: Re: [PATCH V4 3/5] dmaengine/dw_dmac: Divide one sg to many desc, if sg len is greater than DWC_MAX_COUNT
Date: Mon, 9 May 2011 11:33:21 +0530 [thread overview]
Message-ID: <4DC783A9.5060802@st.com> (raw)
In-Reply-To: <1304918425.32447.20.camel@vkoul-udesk3>
On 05/09/2011 10:50 AM, Koul, Vinod wrote:
>> > @@ -695,9 +695,15 @@ dwc_prep_slave_sg(struct dma_chan *chan, struct scatterlist *sgl,
>> > reg = dws->tx_reg;
>> > for_each_sg(sgl, sg, sg_len, i) {
>> > struct dw_desc *desc;
>> > - u32 len;
>> > - u32 mem;
>> > + u32 len, dlen, mem;
>> >
>> > + mem = sg_phys(sg);
>> > + len = sg_dma_len(sg);
>> > + mem_width = 2;
> hardcoding mem_width doesn't make sense, you should take this from input
> params
Firstly, this change is not introduced in this patch, i have just rearranged this.
So, will send separate patch if this change is required.
Secondly, peripheral width is taken from chan->private. And by 2 for mem_width,
we meant word-by-word here. Shouldn't we always try word-by-word here?
How should we pass width for memory?
--
viresh
next prev parent reply other threads:[~2011-05-09 6:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-05 12:00 [PATCH V4 0/5] dmaengine/dw_dmac updates Viresh Kumar
2011-05-05 12:00 ` [PATCH V4 1/5] dmaengine/dw_dmac: don't call callback routine in case dmaengine_terminate_all() is called Viresh Kumar
2011-05-09 5:02 ` Koul, Vinod
2011-05-09 5:45 ` viresh kumar
2011-05-05 12:00 ` [PATCH V4 2/5] dmaengine/dw_dmac: set residue as total len in dwc_tx_status if status is !DMA_SUCCESS Viresh Kumar
2011-05-05 12:00 ` [PATCH V4 3/5] dmaengine/dw_dmac: Divide one sg to many desc, if sg len is greater than DWC_MAX_COUNT Viresh Kumar
2011-05-09 5:20 ` Koul, Vinod
2011-05-09 6:03 ` viresh kumar [this message]
2011-05-09 5:47 ` Koul, Vinod
2011-05-09 6:33 ` viresh kumar
2011-05-09 6:11 ` Koul, Vinod
2011-05-09 8:16 ` viresh kumar
2011-05-05 12:00 ` [PATCH V4 4/5] dmaengine/dw_dmac: Replace spin_lock* with irqsave variants and enable submission from callback Viresh Kumar
2011-05-05 12:00 ` [PATCH V4 5/5] dmaengine/dw_dmac: implement pause and resume in dwc_control Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC783A9.5060802@st.com \
--to=viresh.kumar@st.com \
--cc=armando.visconti@st.com \
--cc=dan.j.williams@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=shiraz.hashim@st.com \
--cc=vinod.koul@intel.com \
--cc=viresh.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox