From: Milan Broz <mbroz@redhat.com>
To: Alasdair G Kergon <agk@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Matthew Wilcox <matthew@wil.cx>,
Zdenek Kabelac <zkabelac@redhat.com>,
Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz>,
linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org,
Hugh Dickins <hughd@google.com>, Oleg Nesterov <oleg@redhat.com>
Subject: Re: [PATCH] Don't mlock guardpage if the stack is growing up
Date: Wed, 11 May 2011 10:42:45 +0200 [thread overview]
Message-ID: <4DCA4C05.4030803@redhat.com> (raw)
In-Reply-To: <20110510225659.GE9253@agk-dp.fab.redhat.com>
On 05/11/2011 12:57 AM, Alasdair G Kergon wrote:
> (What other software packages make use of mlockall() and under what
> circumstances?)
Another one is cryptsetup for commands which manipulate with keys
in memory.
(Users of libcryptetup library are not forced to lock memory, it is optional
call. But cryptsetup itself as libcryptsetup library user always locks memory.)
And I am not happy with mlockall() as well but the lvm2 workaround
is quite complicated.
Basically it wants to lock memory with explicitly allocated keys
(this can be rewritten to use specific locked page though) but it
also need to lock various libdevmapper buffers when issuing dmcrypt
cfg ioctl (mapping table and messages contains key). So that's why
mlockall(MCL_CURRENT|MCL_FUTURE) was the simplest way (and no problems
reported yet).
(No that it is perfect but better than nothing... Of course
more important is to wipe memory with keys after use.)
Milan
next prev parent reply other threads:[~2011-05-11 15:58 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-08 18:55 [PATCH] Don't mlock guardpage if the stack is growing up Mikulas Patocka
2011-05-08 20:12 ` Hugh Dickins
2011-05-09 11:12 ` Mikulas Patocka
2011-05-09 15:57 ` Linus Torvalds
2011-05-09 22:07 ` Linus Torvalds
2011-05-09 22:19 ` James Bottomley
2011-05-09 22:31 ` Linus Torvalds
2011-05-09 22:53 ` Tony Luck
2011-05-09 22:58 ` Linus Torvalds
2011-05-09 23:08 ` Tony Luck
2011-05-09 23:17 ` Linus Torvalds
2011-05-09 23:25 ` Linus Torvalds
2011-05-10 4:12 ` James Bottomley
2011-05-09 22:26 ` Mikulas Patocka
2011-05-15 22:18 ` Mikulas Patocka
2011-05-08 21:47 ` Linus Torvalds
2011-05-09 11:01 ` Mikulas Patocka
2011-05-09 11:43 ` Zdenek Kabelac
2011-05-09 21:08 ` Alasdair G Kergon
2011-05-09 22:45 ` Matthew Wilcox
2011-05-09 22:56 ` Linus Torvalds
2011-05-10 22:57 ` Alasdair G Kergon
2011-05-11 8:42 ` Milan Broz [this message]
2011-05-12 2:12 ` Linus Torvalds
2011-05-12 9:06 ` Zdenek Kabelac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DCA4C05.4030803@redhat.com \
--to=mbroz@redhat.com \
--cc=agk@redhat.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=mikulas@artax.karlin.mff.cuni.cz \
--cc=oleg@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=zkabelac@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox