From: Michal Marek <mmarek@suse.cz>
To: mfmooney@gmail.com
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [Resend PATCH] package: Makefile: fix perf target bug
Date: Thu, 12 May 2011 22:30:29 +0200 [thread overview]
Message-ID: <4DCC4365.3030907@suse.cz> (raw)
In-Reply-To: <1d7d3b31c0da82ce8ce75778922155b7004a8f7e.1305224477.git.mfm@muteddisk.com>
On 12.5.2011 20:25, mfmooney@gmail.com wrote:
> diff --git a/scripts/package/Makefile b/scripts/package/Makefile
> index 1b7eaea..a32dc2d 100644
> --- a/scripts/package/Makefile
> +++ b/scripts/package/Makefile
> @@ -118,10 +118,14 @@ perf-tar=perf-$(KERNELVERSION)
>
> quiet_cmd_perf_tar = TAR
> cmd_perf_tar = \
> -git archive --prefix=$(perf-tar)/ HEAD^{tree} \
> - $$(cat $(srctree)/tools/perf/MANIFEST) -o $(perf-tar).tar; \
> +git --git-dir=$(srctree)/.git --work-tree=$(srctree) \
Neither git archive not git rev-parse need the work tree, --git-dir=..
is sufficient.
Michal
> + archive --prefix=$(perf-tar)/ HEAD^{tree} \
> + $(addprefix $(srctree)/, \
> + $(shell cat $(srctree)/tools/perf/MANIFEST)) \
> + -o $(perf-tar).tar; \
> mkdir -p $(perf-tar); \
> -git rev-parse HEAD > $(perf-tar)/HEAD; \
> +git --git-dir=$(srctree)/.git --work-tree=$(srctree) \
> + rev-parse HEAD > $(perf-tar)/HEAD; \
> tar rf $(perf-tar).tar $(perf-tar)/HEAD; \
> rm -r $(perf-tar); \
> $(if $(findstring tar-src,$@),, \
next prev parent reply other threads:[~2011-05-12 20:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-12 18:25 [Resend PATCH] package: Makefile: fix perf target bug mfmooney
2011-05-12 20:30 ` Michal Marek [this message]
2011-05-12 21:07 ` matt mooney
2011-05-12 21:20 ` Michal Marek
2011-05-12 21:38 ` matt mooney
2011-05-13 0:09 ` [PATCH v2] " mfmooney
2011-05-13 8:26 ` [Resend PATCH] " Michal Marek
2011-05-13 18:52 ` matt mooney
2011-05-13 19:56 ` Michal Marek
2011-05-13 23:26 ` matt mooney
2011-05-13 23:41 ` [PATCH v3] " mfmooney
2011-05-15 15:40 ` Arnaldo Carvalho de Melo
2011-05-16 8:19 ` Michal Marek
2011-06-12 18:19 ` matt mooney
2011-06-24 13:22 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DCC4365.3030907@suse.cz \
--to=mmarek@suse.cz \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mfmooney@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox