* [PATCH] mfd: Fix off-by-one value range checking for tps65910_i2c_write
@ 2011-05-13 9:13 Axel Lin
2011-05-13 17:46 ` Samuel Ortiz
0 siblings, 1 reply; 3+ messages in thread
From: Axel Lin @ 2011-05-13 9:13 UTC (permalink / raw)
To: linux-kernel; +Cc: Graeme Gregory, Jorge Eduardo Candelaria, Samuel Ortiz
If bytes == (TPS65910_MAX_REGISTER + 1), we have a buffer overflow when
doing memcpy(&msg[1], src, bytes).
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/mfd/tps65910.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mfd/tps65910.c b/drivers/mfd/tps65910.c
index bf649cf..e318248 100644
--- a/drivers/mfd/tps65910.c
+++ b/drivers/mfd/tps65910.c
@@ -71,7 +71,7 @@ static int tps65910_i2c_write(struct tps65910 *tps65910, u8 reg,
u8 msg[TPS65910_MAX_REGISTER + 1];
int ret;
- if (bytes > (TPS65910_MAX_REGISTER + 1))
+ if (bytes > TPS65910_MAX_REGISTER)
return -EINVAL;
msg[0] = reg;
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mfd: Fix off-by-one value range checking for tps65910_i2c_write
2011-05-13 9:13 [PATCH] mfd: Fix off-by-one value range checking for tps65910_i2c_write Axel Lin
@ 2011-05-13 17:46 ` Samuel Ortiz
2011-05-16 12:26 ` Liam Girdwood
0 siblings, 1 reply; 3+ messages in thread
From: Samuel Ortiz @ 2011-05-13 17:46 UTC (permalink / raw)
To: Axel Lin, Liam Girdwood
Cc: linux-kernel, Graeme Gregory, Jorge Eduardo Candelaria
Hi Axel,
On Fri, May 13, 2011 at 05:13:57PM +0800, Axel Lin wrote:
> If bytes == (TPS65910_MAX_REGISTER + 1), we have a buffer overflow when
> doing memcpy(&msg[1], src, bytes).
This code is going through Liam's tree, I'm adding him to this thread.
Liam, please add my Acked-by to this patch, if you think it's needed.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mfd: Fix off-by-one value range checking for tps65910_i2c_write
2011-05-13 17:46 ` Samuel Ortiz
@ 2011-05-16 12:26 ` Liam Girdwood
0 siblings, 0 replies; 3+ messages in thread
From: Liam Girdwood @ 2011-05-16 12:26 UTC (permalink / raw)
To: Axel Lin
Cc: Samuel Ortiz, linux-kernel@vger.kernel.org, Graeme Gregory,
Jorge Eduardo Candelaria
On 13/05/11 18:46, Samuel Ortiz wrote:
> Hi Axel,
>
> On Fri, May 13, 2011 at 05:13:57PM +0800, Axel Lin wrote:
>> If bytes == (TPS65910_MAX_REGISTER + 1), we have a buffer overflow when
>> doing memcpy(&msg[1], src, bytes).
> This code is going through Liam's tree, I'm adding him to this thread.
> Liam, please add my Acked-by to this patch, if you think it's needed.
>
Axel, could you resend to me with Samuels Ack and I'll apply.
Thanks
Liam
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-05-16 12:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-13 9:13 [PATCH] mfd: Fix off-by-one value range checking for tps65910_i2c_write Axel Lin
2011-05-13 17:46 ` Samuel Ortiz
2011-05-16 12:26 ` Liam Girdwood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox