public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Fabien Marteau <fabien.marteau@armadeus.com>
To: Guenter Roeck <guenter.roeck@ericsson.com>
Cc: "khali@linux-fr.org" <khali@linux-fr.org>,
	"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] hwmon: Driver for as1531, Austria-Microsystem Analog to Digital Converter.
Date: Tue, 17 May 2011 09:06:06 +0200	[thread overview]
Message-ID: <4DD21E5E.9000605@armadeus.com> (raw)
In-Reply-To: <20110516153900.GA31255@ericsson.com>

Hi Guenter,

Thanks for the review.

On 16/05/2011 17:39, Guenter Roeck wrote:
> On Mon, May 16, 2011 at 09:39:14AM -0400, fabien.marteau@armadeus.com wrote:
>> From: Fabien Marteau <fabien.marteau@armadeus.com>
>>
>>
> Some description, such as "Dhis driver adds support for xxx" would be nice.
> 
> Also, I wonder if this driver belongs into hwmon in the first place. It is
> a generic ADC chip with high conversion rate. iio would probably be more
> appropriate and also much better in supporting high speed readings.
I provided this driver "as is" because it's a driver that work well on
our platform. I thought that iio was not stable enough driver framework
to be used.
I can rewrite it under iio framework but I have no time for this moment
to do that. You think it's better to wait for an iio driver or to
continue commiting this ?

regards,
Fabien M

  reply	other threads:[~2011-05-17  7:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-16 13:39 [PATCH] hwmon: Driver for as1531, Austria-Microsystem Analog to Digital Converter fabien.marteau
2011-05-16 15:01 ` Randy Dunlap
2011-05-16 15:39 ` Guenter Roeck
2011-05-17  7:06   ` Fabien Marteau [this message]
2011-05-17  9:25     ` Jonathan Cameron
2011-05-17  9:34       ` Jonathan Cameron
2011-05-17 11:59         ` Fabien Marteau
2011-05-17 13:38       ` Guenter Roeck
2011-05-18 13:09 ` Jonathan Cameron
2011-05-18 15:05   ` Jonathan Cameron
  -- strict thread matches above, loose matches on Subject: below --
2011-05-16 13:39 fabien.marteau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DD21E5E.9000605@armadeus.com \
    --to=fabien.marteau@armadeus.com \
    --cc=guenter.roeck@ericsson.com \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox