From: Jens Axboe <axboe@kernel.dk>
To: Shaohua Li <shaohua.li@intel.com>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH]block: don't delay blk_run_queue_async
Date: Wed, 18 May 2011 11:11:35 +0200 [thread overview]
Message-ID: <4DD38D47.9010505@kernel.dk> (raw)
In-Reply-To: <1305708151.2375.115.camel@sli10-conroe>
On 2011-05-18 10:42, Shaohua Li wrote:
> Let's check a scenario:
> 1. blk_delay_queue(q, SCSI_QUEUE_DELAY);
> 2. blk_run_queue_async();
> the second one will became a noop, because q->delay_work already has
> WORK_STRUCT_PENDING_BIT set, so the delayed work will still run after
> SCSI_QUEUE_DELAY. But blk_run_queue_async actually hopes the delayed
> work runs immediately.
Good catch. I wonder if it wouldn't be better to "fix"
queue_delayed_work() instead. If the time passed in is before the
scheduled event, adjust the timeout.
But as a 2.6.39 fix, this is good, will queue up.
--
Jens Axboe
prev parent reply other threads:[~2011-05-18 9:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-18 8:42 [PATCH]block: don't delay blk_run_queue_async Shaohua Li
2011-05-18 9:11 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DD38D47.9010505@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).