From: Jens Axboe <jaxboe@fusionio.com>
To: "Alex,Shi" <alex.shi@intel.com>
Cc: "Li, Shaohua" <shaohua.li@intel.com>,
"James.Bottomley@hansenpartnership.com"
<James.Bottomley@hansenpartnership.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Perfromance drop on SCSI hard disk
Date: Thu, 19 May 2011 20:27:16 +0200 [thread overview]
Message-ID: <4DD56104.6080801@fusionio.com> (raw)
In-Reply-To: <1305793580.22968.155.camel@debian>
On 2011-05-19 10:26, Alex,Shi wrote:
>
>> I will queue up the combined patch, it looks fine from here as well.
>>
>
> When I have some time to study Jens and shaohua's patch today. I find a
> simpler way to resolved the re-enter issue on starved_list. Following
> Jens' idea, we can just put the starved_list device into kblockd if it
> come from __scsi_queue_insert().
> It can resolve the re-enter issue and recover performance totally, and
> need not a work_struct in every scsi_device. The logic/code also looks a
> bit simpler.
> What's your opinion of this?
Isn't this _identical_ to my original patch, with the added async run of
the queue passed in (which is important, an oversight)?
--
Jens Axboe
next prev parent reply other threads:[~2011-05-19 18:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-10 6:40 Perfromance drop on SCSI hard disk Alex,Shi
2011-05-10 6:52 ` Shaohua Li
2011-05-12 0:36 ` Shaohua Li
2011-05-12 20:29 ` Jens Axboe
2011-05-13 0:11 ` Alex,Shi
2011-05-13 0:48 ` Shaohua Li
2011-05-13 3:01 ` Shaohua Li
2011-05-16 8:04 ` Shaohua Li
2011-05-16 8:37 ` Alex,Shi
2011-05-17 6:09 ` Alex,Shi
2011-05-17 7:20 ` Jens Axboe
2011-05-19 8:26 ` Alex,Shi
2011-05-19 8:47 ` Alex,Shi
2011-05-19 18:27 ` Jens Axboe [this message]
2011-05-20 0:22 ` Alex,Shi
2011-05-20 0:40 ` Shaohua Li
2011-05-20 5:17 ` Alex,Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DD56104.6080801@fusionio.com \
--to=jaxboe@fusionio.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=alex.shi@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox