Re: [PATCH 3/5] oom: oom-killer don't use proportion of system-ram internally

KOSAKI Motohiro
2011-05-24T01:45:04Z

>> @@ -176,33 +178,49 @@ unsigned int oom_badness(struct task_struct *p, struct mem_cgroup *mem,
>> */
>> points = get_mm_rss(p->mm) + p->mm->nr_ptes;
>> points += get_mm_counter(p->mm, MM_SWAPENTS);
>> -
>> - points *= 1000;
>> - points /= totalpages;
>> task_unlock(p);
>>
>> /*
>> * Root processes get 3% bonus, just like the __vm_enough_memory()
>> * implementation used by LSMs.
>> + *
>> + * XXX: Too large bonus, example, if the system have tera-bytes memory..
>> */
>
> Nitpick. I have no opposition about adding this comment.
> But strictly speaking, the comment isn't related to this patch.
> No biggie and it's up to you. :)

ok, removed.

From 3dda8863e5acdba7a714f0e7506fae931865c442 Mon Sep 17 00:00:00 2001
From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Date: Tue, 24 May 2011 10:43:49 +0900
Subject: [PATCH] remove unrelated comments

Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
---
mm/oom_kill.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/mm/oom_kill.c b/mm/oom_kill.c
index ec075cc..b01fa64 100644
--- a/mm/oom_kill.c
+++ b/mm/oom_kill.c
@@ -184,8 +184,6 @@ unsigned long oom_badness(struct task_struct *p, struct mem_cgroup *mem,
/*
* Root processes get 3% bonus, just like the __vm_enough_memory()
* implementation used by LSMs.
- *
- * XXX: Too large bonus, example, if the system have tera-bytes memory..
*/
if (protect_root && has_capability_noaudit(p, CAP_SYS_ADMIN)) {
if (points >= totalpages / 32)
--
1.7.3.1