linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jens Axboe <jaxboe@fusionio.com>
To: "Gustavo F. Padovan" <padovan@profusion.mobi>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Christoph Hellwig <hch@lst.de>,
	Artem Bityutskiy <Artem.Bityutskiy@nokia.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Dave Chinner <dchinner@redhat.com>,
	open list: MEMORY MANAGEMENT <linux-mm@kvack.org>, ;
Subject: Re: [PATCH 1/8] mm: Kill set but not used var in  bdi_debug_stats_show()
Date: Fri, 20 May 2011 21:23:00 +0200	[thread overview]
Message-ID: <4DD6BF94.7000902@fusionio.com> (raw)
In-Reply-To: <1305918786-7239-1-git-send-email-padovan@profusion.mobi>

On 2011-05-20 21:12, Gustavo F. Padovan wrote:
> Signed-off-by: Gustavo F. Padovan <padovan@profusion.mobi>
> ---
>  mm/backing-dev.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/backing-dev.c b/mm/backing-dev.c
> index befc875..f032e6e 100644
> --- a/mm/backing-dev.c
> +++ b/mm/backing-dev.c
> @@ -63,10 +63,10 @@ static int bdi_debug_stats_show(struct seq_file *m, void *v)
>  	unsigned long background_thresh;
>  	unsigned long dirty_thresh;
>  	unsigned long bdi_thresh;
> -	unsigned long nr_dirty, nr_io, nr_more_io, nr_wb;
> +	unsigned long nr_dirty, nr_io, nr_more_io;
>  	struct inode *inode;
>  
> -	nr_wb = nr_dirty = nr_io = nr_more_io = 0;
> +	nr_dirty = nr_io = nr_more_io = 0;
>  	spin_lock(&inode_wb_list_lock);
>  	list_for_each_entry(inode, &wb->b_dirty, i_wb_list)
>  		nr_dirty++;

Good catch, nr_wb should have been killed with the removal of the worker
list. I'll queue this up.

-- 
Jens Axboe


      parent reply	other threads:[~2011-05-20 19:23 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-20 19:12 [PATCH 1/8] mm: Kill set but not used var in bdi_debug_stats_show() Gustavo F. Padovan
2011-05-20 19:12 ` [PATCH 2/8] x86: Fix set but not used in ghash_async_setkey() Gustavo F. Padovan
2011-05-20 19:13   ` [PATCH 3/8] x86: Kill set but not used warning Gustavo F. Padovan
2011-05-20 19:13     ` [PATCH 4/8] x86: Kill set but not used warnings in tlb_uv.c Gustavo F. Padovan
2011-05-20 19:13       ` [PATCH 5/8] x86: Kill set but not used warning in test_NX() Gustavo F. Padovan
2011-05-20 19:13         ` [PATCH 6/8] x86: Kill set but not used warnings in pf_in.c Gustavo F. Padovan
2011-05-20 19:13           ` [PATCH 7/8] 9p: Kill set but not used warnings Gustavo F. Padovan
2011-05-20 19:13             ` [PATCH 8/8] apparmor: Kill set but no used warning in common_mmap() Gustavo F. Padovan
2011-05-21 17:21     ` [tip:x86/urgent] x86: Eliminate various 'set but not used' warnings tip-bot for Gustavo F. Padovan
2011-05-23 10:17     ` [PATCH 3/8] x86: Kill set but not used warning Roedel, Joerg
2011-05-23 10:18       ` Ingo Molnar
2011-05-26  3:29   ` [PATCH 2/8] x86: Fix set but not used in ghash_async_setkey() Herbert Xu
2011-05-20 19:23 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DD6BF94.7000902@fusionio.com \
    --to=jaxboe@fusionio.com \
    --cc=Artem.Bityutskiy@nokia.com \
    --cc=akpm@linux-foundation.org \
    --cc=dchinner@redhat.com \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=padovan@profusion.mobi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).