From: "H. Peter Anvin" <hpa@zytor.com>
To: John Kacur <jkacur@redhat.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Eduardo Silva <edsiper@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel: Fix ftrace.c compiler warning when calling ftrace_nop_replace()
Date: Mon, 23 May 2011 13:05:06 -0700 [thread overview]
Message-ID: <4DDABDF2.1080704@zytor.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1105232159350.4933@localhost6.localdomain6>
On 05/23/2011 01:01 PM, John Kacur wrote:
> On Mon, 23 May 2011, Steven Rostedt wrote:
>> The real solution is to change all the users into const *. This should
>> be doable as the new and old pointers are not modified.
>
> From 71d6e5971cc90a03fd2d7bf8aaa2b81932bd0c7c Mon Sep 17 00:00:00 2001
> From: John Kacur <jkacur@redhat.com>
> Date: Mon, 23 May 2011 21:24:27 +0200
> Subject: [PATCH] ftrace: Change unsigned char *new, *old to const
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> This removes the warning:
> arch/x86/kernel/ftrace.c: In function ‘ftrace_make_nop’:
> /arch/x86/kernel/ftrace.c:308: warning: assignment discards qualifiers from pointer target type
>
> Steven Rostedt suggested to make these pointers const pointers.
>
> This patch assumes that
> https://patchwork.kernel.org/patch/798172/
> is applied first.
>
> Reported-by: Eduardo Silva <edsiper@gmail.com>
> Signed-off-by: John Kacur <jkacur@redhat.com>
Looks much better.
Acked-by: H. Peter Anvin <hpa@zytor.com>
-hpa
prev parent reply other threads:[~2011-05-23 20:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-23 1:19 [PATCH] kernel: Fix ftrace.c compiler warning when calling ftrace_nop_replace() Eduardo Silva
2011-05-23 1:36 ` H. Peter Anvin
2011-05-23 2:27 ` Eduardo Silva
2011-05-23 13:08 ` Steven Rostedt
2011-05-23 20:01 ` John Kacur
2011-05-23 20:05 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDABDF2.1080704@zytor.com \
--to=hpa@zytor.com \
--cc=edsiper@gmail.com \
--cc=fweisbec@gmail.com \
--cc=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).